search

jellyfin-archive / jellyfin-desktop

Desktop Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
180 stars 45 forks source link

MPV integration #12

Open ninnghazad opened 5 years ago

ninnghazad commented 5 years ago

i understood this to be local version of the webgui which would allow me to play media using mpv. it does however use whatever player is integrated with chromium it seems. are there any additional requirements for it to use the mpv installed on the system? using debian with minimal wm (blackbox).

ghost commented 5 years ago

Hello @ninnghazad sorry for the late response but there quite a bit of dependency's for this application I don't have all of them written down. But hopefully here is a breakdown of your question I believe.

i understood this to be local version of the webgui which would allow me to play media using mpv.

Yes this allows you to play videos / movies and listen to music on your desktop. But its not a local version of the webgui. This just enables you to view them on your pc without a full fledged browser (if you'd call it that). This is written in electron which only loads the URL of the website and displays it through this frame on your desktop.

it does however use whatever player is integrated with chromium it seems.

That player is identical to the one in the web browser because it is the one in the web browser

are there any additional requirements for it to use the mpv installed on the system?

Yes there are quite a few. The only ones we require you to install on your own are Node JS and Npm. After that npm handles all of our deps through its package manager. It does install quite a bit. By the end of the day it is quite hefty.

ninnghazad commented 5 years ago

thanks for the information. but how do i actually get it to use mpv? i have installed using npm, and can start it and watch stuff - just not using mpv. a minimal test using the node-mpv that came as a dependency through npm works - it plays files with the correct mpv and it's configs/plugins. it seems that whatever plugin/script/thingy make electron/chromium use the external player won't work for me. i can see mpvplayer.js getting added to plugins-option on startup, but a few console.logs thrown at the source don't show any mpv* related stuff getting actually called.

cromefire commented 4 years ago

MPV is already integrated, but not working at all (like the rest of the app). I'll fix it soonish (depending on how fast the PRs get reviewed)