search

jellyfin-archive / jellyfin-desktop

Desktop Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
180 stars 45 forks source link

Rename project #2

Closed gravypod closed 5 years ago

joshuaboniface commented 5 years ago

Description for context: removes a number of node_modules that were present but should be ignored, and replaces the name "Emby" with "Jellyfin" throughout.

gravypod commented 5 years ago

Thanks for the quick merge @joshuaboniface. Do you know anything about this tv.emby.media domain? Just as a test I've built a copy of this and pointed it at my emby server and everything worked correctly. I'd like to remove this external dependency of tv.emby.media domain from this project if possible.

joshuaboniface commented 5 years ago

I'm not too sure what it does (I haven't used Emby TV/Theater, or had a premium subscription myself), but if it works after stripping it out go for it! We don't plan to have any centrally-hosted dependencies at all.

gravypod commented 5 years ago

@joshuaboniface I don't think it will work with stripping the domain out. I'll do some more research later and I'll comment on the main issue I created on the project. I've opened up the extra PR to document the build process in the mean time.

Happy holidays!

joshuaboniface commented 5 years ago

Thanks! I also merged that one in ;-)