jellyfin-archive / jellyfin-desktop

Desktop Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
180 stars 45 forks source link

Dialog box for Windows #9

Closed ObiWanTwo closed 4 years ago

ObiWanTwo commented 5 years ago

Currently Jellyfin Theater electron does not have a dialog box in order to close/minimize the app. It would really be nice to have that otherwise it's really hard to move the client around.

lachlan-00 commented 5 years ago

looks like a frameless window? https://electronjs.org/docs/api/frameless-window

main.js has the frame set to false.

var windowOptions = {
            transparent: false, //supportsTransparency,
            frame: false,
            resizable: false,
            title: 'Jellyfin Theater',
            minWidth: 720,
            minHeight: 480,
            //alwaysOnTop: true,
skipTaskbar: isWindows() ? false : true,
lachlan-00 commented 5 years ago

Linux has pretty easy windows manipulation without a decoration but i can see windows people getting frustrated unless they use Win + arrows or a separate tool like AltWindowsDrag

lachlan-00 commented 5 years ago

Setting frame to true at least gets you a window decoration but the size for me is forced so i can't maximise. image

ghost commented 5 years ago

Many users have complained about this, I belive though (not quite sure) that the original intention of this app was to be for a home theater pc so it would just load up on something like a raspberry pi or something light weight. Once i finish perfecting this i will setup a little windowed version for desktops and such. Sorry for the inconvenience.

Later i will post how you can hack the code and change it to windowed mode your self if you would like,

ObiWanTwo commented 5 years ago

Since the repo of jellyfin theater for windows is empty I used the electron version. Now that you stated the purpose of the app I understand better why this feature is lacking. I will stick with @lachlan-00's solution for now. Thank you for your answers!

cromefire commented 4 years ago

Duplicate of #11