search

jellyfin-archive / jellyfin-react-client

Next Generation Client for Jellyfin
https://jellyfin.org
Mozilla Public License 2.0
86 stars 29 forks source link

Changes to support Android build errors #37

Closed deerparker closed 4 years ago

deerparker commented 4 years ago

Few changes to allow Android build to complete.

This might have just been my environment but I also had to run this to get past an error https://github.com/gatsbyjs/gatsby/issues/11406#issuecomment-458769756

Now builds the Android app (and a quick test that it didnt break web worked fine)

deerparker commented 4 years ago

Worth also saying, if it fails to run on the device first time, I had to also follow this manually afterwards - https://medium.com/@adityasingh_32512/solved-unable-to-load-script-from-assets-index-android-bundle-bdc5e3a3d5ff

deerparker commented 4 years ago

lock files in the pull request by mistake. you can ignore them!

EraYaN commented 4 years ago

One last thing, is that bundle required for Android? It seems like it’s generated code, if so please add it to the .gitignore file.

deerparker commented 4 years ago

One last thing, is that bundle required for Android? It seems like it’s generated code, if so please add it to the .gitignore file.

That's the file removed and .gitignore updated. The file is generated is linked to this comment I added above https://github.com/jellyfin/jellyfin-react-client/pull/37#issuecomment-559872237

EraYaN commented 4 years ago

Alright thanks for the PR.