Add eslint (Close #20) - Githubissues

jellyfin-archive / jellyfin-react-client

Next Generation Client for Jellyfin

https://jellyfin.org

Mozilla Public License 2.0

85 stars 30 forks source link

Closed kesslern closed 4 years ago

kesslern commented 4 years ago

Add basic eslintrc.js that extends eslint:recommended, plugin:react/recommended, and plugin:@typescript-eslint/eslint-recommended
Add lint task in package.json to run eslint
Add ignore and global reference to registerServiceWorker.js so yarn lint runs successfully

kesslern commented 4 years ago

I realized shortly after opening this that the typescript files aren't being scanned. This isn't quite ready for review yet.

kesslern commented 4 years ago

Hi, I think this is ready to review.

Add partial ClientApi type definition
Remove most usages of any types. There are a few left around the Redux usage that are individually ignored.
Completely ignore registerServiceWorker.js. I couldn't find a way to avoid applying the typescript rules to JS files.

Everything in the web client is working for me and the lint task runs successfully.