jellyfin / Swiftfin

Native Jellyfin Client for iOS and tvOS
Mozilla Public License 2.0
2.57k stars 281 forks source link

IOS's "Spatial Audio" feature doesn't work with Swiftfin #107

Closed michaelharmonart closed 3 years ago

michaelharmonart commented 3 years ago

I know the standard jellyfin ios app can playback surround sound videos with spatial audio as long as it's transcoded to aac and the app is set to use the native player. I know Swiftfin is based on mpv, so I don't know if it's possible to support the spatial audio feature, but I think it would make a great addition.

acvigue commented 3 years ago

we use libvlc. libvlc doesn't have support for spatial audio

michaelharmonart commented 3 years ago

Ah apologies, I guess I misremembered some comment about possibly switching to libmpv as allready having happened which isn't the case. I'll close the issue since clearly this is a libvlc problem.

michaelharmonart commented 3 years ago

Although I suppose I should ask. If I should be pounding on someone's door to support this, where would I do that? Would I put an issue up for libvlc, vlc itself, VLCkit? Is there plans from vlc to support this already?

acvigue commented 3 years ago

I think the door to pound on would be VLCKit :p

Sent from my iPhone

On Jul 14, 2021, at 11:38 PM, Michael Harmon @.***> wrote:

 Although I suppose I should ask. If I should be pounding on someone's door to support this, where would I do that? Would I put an issue up for libvlc, vlc itself, VLCkit? Is there plans from vlc to support this already?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

michaelharmonart commented 3 years ago

https://code.videolan.org/videolan/VLCKit/-/issues/514 Just if you want to stay updated

sbucdaivs commented 2 years ago

It looks like spatial audio support was added to libvlc. Would it be possible to reopen the issue? https://code.videolan.org/videolan/VLCKit/-/merge_requests/105

LePips commented 2 years ago

No, as we would still have to wait for VLCKit v4 to be released with all of the libvlc improvements in the recent years.

VLCKit v4 won't go unnoticed and will be a big improvement, it will have a special announcement.