search

jellyfin / Swiftfin

Native Jellyfin Client for iOS and tvOS
Mozilla Public License 2.0
2.49k stars 271 forks source link

Swiftfin Player Compact Button Load Error #1124

Open JPKribs opened 2 months ago

JPKribs commented 2 months ago

Describe the bug

I have a few Blu-ray’s I have encoded that refuse to start in the Swiftfin Player but only when the Compact Player Buttons are selected. It only impacts a couple of movies so it could be codec related (see images). When Compact Buttons are select it gives me a black screen, doesn’t not report playback on the Server, and produces no logs. Changing to Large Buttons resolves this.

I would say 95% of things I’ve encoded with the exact same handbrake settings don’t have this error. This could be hard to reproduce but I thought I’d throw an Issue out there in case someone else experiences it.

Large Buttons:

https://github.com/jellyfin/Swiftfin/assets/37599297/6ec9fae5-39ea-43cc-833a-f7a035e2e849

Compact Buttons:

https://github.com/jellyfin/Swiftfin/assets/37599297/a0cda392-fb98-4631-9719-565a46a3ba84

Video Info:

IMG_8828

IMG_8827

IMG_8826

Application version

1.1

Where did you install the app from?

App Store

Device information

iPhone 13 Pro Max

OS version

iOS 17.5.1

Jellyfin server version

10.9.6

JPKribs commented 2 months ago

I've spent some time debugging it and this is honestly so weird. This issue only occurs on certain movies. Only when Small Buttons and Capsule timeline are selected. In the code, it just loops through the SmallPlaybackButtons struct over and over.

I think it has an issue with the .leadingContent for the Capsule Slider? But I have no idea why it only impacts some movies but not others. They should all be the same handbrake setting?

All in all, it's not a big issue. More just weird.

JPKribs commented 2 months ago

To add, changing away from Capsule resolves this as well.