search

jellyfin / Swiftfin

Native Jellyfin Client for iOS and tvOS
Mozilla Public License 2.0
2.5k stars 272 forks source link

The "Reset" button in Filters in search doesn't work #1246

Open FrankreedX opened 12 hours ago

FrankreedX commented 12 hours ago

Describe the bug

Go to the Search tab click on any filter below the search bar choose any filter click on the "Reset" button The previous choice will not be reverted

Application version

1.2 (4)

Where did you install the app from?

TestFlight

Device information

iPhone 11 Pro

OS version

iOS 18.0

Jellyfin server version

10.9.11

FrankreedX commented 12 hours ago

Ok it does work, but the drawer view does not update. Only when you exit will you see the change

JPKribs commented 12 hours ago

Just tried testing this and I think this applies to both Library and Search filters. Are you seeing this as well?

FrankreedX commented 12 hours ago

Yes

FrankreedX commented 12 hours ago

O btw, I'm new to swift and contributing and would love to have this as my first ticket if possible. How do yall do that around here?

JPKribs commented 12 hours ago

I'm absolutely not the authority for Swiftfin but I got started by looking at this: https://github.com/jellyfin/Swiftfin/blob/main/contributing.md

Then, I would make an In-Progress PR, from your fork, with this issue linked just so everyone knows what you're working on!

Always exciting to see new contributors!

FrankreedX commented 11 hours ago

Ok I thought this issue was simple but it's actually a web of Bindings that I'm still trying to wrap my head around... It probably has something to do with this warning though Screenshot 2024-09-23 at 10 44 22 PM