Open ikheetjeff opened 2 weeks ago
It might be some trick cases that my workaround doesn't handle well.
I think @LePips is working on refactoring related code in #1203. I hope it fix this if the whole logic is re-written.
BTW, it is good cases that we might want some unit-test to ensure this handled correctly.
I have the same issue.
Unfortunately I'm having the same issue as well.
This is the same issue I have
Last update in AppStore indicates that the issue solved , did you guys still have it. Since I still facing the issue and tried everything to workaround it but no luck.
Last update & test flight
still facing the issue no luck
internal subtitles works but external subtitles switches back to "none"
@LePips do you have any refactor progress could share? I am thinking if we should take immediate action to revert #1219 since the patch get more complain on this thread than #1207
I believe the goal is for this refactor to be shipped in the 1.3 final version:
https://github.com/jellyfin/Swiftfin/issues/1265#issuecomment-2415679656
Describe the bug
Thank you all for this fantastic app.
When I click on a subtitle, I expect it to load. However, that doesn’t happen: it switches back to "none" and doesn’t display any subtitles. This occurs with all SUBRIP languages in this video. However, it doesn’t happen with all series/movies. I haven’t been able to find a reason why it doesn’t work with this file but does with other films/series.
I’ve tried the following:
When I installed an earlier TestFlight build (1.2 (3)), the problem was resolved. The issue is also not present in the App Store version.
I suspect it is related to this PR: https://github.com/jellyfin/Swiftfin/pull/1219 Hopefully, @cebrusfs, you can take a look at this due to your previous commit. My apologies if this tag is not appreciated.
This video shows the bug: (TestFlight 1.2 (4))
https://github.com/user-attachments/assets/d776c40a-5a65-460b-bf07-8975981ee151
This is how it should work: (TestFlight 1.2 (3) / App Store version)
https://github.com/user-attachments/assets/150b29ab-406b-4382-ad2a-ed7784527d7b
Original media file (added the SUBRIP manualy in jellyfin)
Application version
1.2 (4)
Where did you install the app from?
TestFlight
Device information
iPhone 14 Pro Max
OS version
iOS 18.0.1
Jellyfin server version
10.9.11