search

jellyfin / jellycon

Kodi Addon for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
295 stars 27 forks source link

Add HDR/SDR icons to movie details #117

Open danbezerra opened 2 years ago

danbezerra commented 2 years ago

When using the local Kodi DB, the HDR/SDR information must come from the actual file name - such as .HDR.MKV. However, this information is available at the Jellyfin Server side. Would be possible to parse the HDR/SDR information from Jellyfin and display the icon as appropriate when browsing on Kodi via Jellycon?

Thanks!

mcarlton00 commented 2 years ago

How is the HDR information displayed? I don't have any files to test that against and see it for myself.

It's currently looking like it might not be possible for an addon to hook into this, but I'm waiting for a response from the Kodi devs before I can confirm for sure. If we can't hook into Kodi's internal system then it would be possible to still do it just in the movie name. Appending - (HDR) or something to the names, but that's pretty ugly and not ideal imo.

mcarlton00 commented 2 years ago

Update: heard back from the Kodi devs. It's not currently possible for a python addon to hook into the hdr status.

Edit: Will be coming in Kodi version 20. https://github.com/xbmc/xbmc/pull/21104

danbezerra commented 2 years ago

Thanks for the research! As of Today, Kodi needs to see "HDR" as part of the filename in order to show the HDR badge. Since Jellyfin Server has the HDR/SDR information available today, I was hoping that Jellycon could use it instead of the filename requirement.

Guess we need to wait until Kodi 20!

danbezerra commented 9 months ago

@mcarlton00 , now that we have Kodi 20, is this something that could be added to Jellycon? I tested and if I add a HDR video directly on Kodi Video Library, a new HDR flag shows up in the properties. But not when using Kodi 20 + Jellycon.