jellyfin / jellycon

Kodi Addon for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
294 stars 27 forks source link

On resources/lib/play_utils.py 1229 : "# live tv has to be transcoded by the server" NOT #340

Open xxzandy opened 3 weeks ago

xxzandy commented 3 weeks ago

Describe the bug

On resources/lib/play_utils.py 1229 : "# live tv has to be transcoded by the server

Kodi can consume live TV in various formats. No it definitely has not to force-transcode unless bitrate limit says so. Kodi can take any live tv stream (and efficiently deinterlace, show all subtitles etc.) without transcoding. Force-transcoding kills a lot (like the subtitles). Deinterlace is best to leave for the client (Kodi) to do. This is Jellycon, so the client is always Kodi.

To Reproduce 1, Add tvheadend in Jellyfin as tv source addon

Expected behavior See live tv with subtitles without any additional load on the server

Logs

System (please complete the following information):

Repeating myself: Kodi (proved by its PVR addons), can consume the stream without transcoding. It should not be forced.

mcarlton00 commented 3 weeks ago

That comment has nothing to do with Kodi's capabilities. At the time of writing, the Jellyfin server was incapable of blindly passing a livetv stream through to a client. So if you wanted to watch live tv through Jellyfin, it had to be transcoded. I'm not sure if this is still the case or not

xxzandy commented 3 weeks ago

Thanks for your response and the work you have done for Jellyfin!

I will look into that more deeply. Direct play works with Jelllyfin client, so that's one benchmark. I hope dvbsub:s would also get some attention. Let's see.

BR, A

From: mcarlton00 @.> Sent: torstai 6. kesäkuuta 2024 23.40 To: jellyfin/jellycon @.> Cc: Lehtinen Antti @.>; Author @.> Subject: Re: [jellyfin/jellycon] On resources/lib/play_utils.py 1229 : "# live tv has to be transcoded by the server" NOT (Issue #340)

That comment has nothing to do with Kodi's capabilities. At the time of writing, the Jellyfin server was incapable of blindly passing a livetv stream through to a client. So if you wanted to watch live tv through Jellyfin, it had to be transcoded. I'm not sure if this is still the case or not

- Reply to this email directly, view it on GitHubhttps://github.com/jellyfin/jellycon/issues/340#issuecomment-2153369850, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BARQXEKRUDOMDOWNFHOIPQ3ZGDCKVAVCNFSM6AAAAABI5MWJBGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJTGM3DSOBVGA. You are receiving this because you authored the thread.Message ID: @.**@.>>