search

jellyfin / jellycon

Kodi Addon for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
317 stars 30 forks source link

Rename device in metadata sent to server #80

Open mcarlton00 opened 3 years ago

mcarlton00 commented 3 years ago

Describe the bug

In the event that you have multiple JellyCon instances, you can't tell which device is which from the casting menu in the server.

Screenshots

2021-08-29-095713_224x411_scrot

krruzic commented 3 years ago

How do you see this being implemented? I might try to take it on, would this be a configuration option in settings where the user specifies the device name? What about a default name by using the device hostname?

TrueTechy commented 3 years ago

That's pretty much how the jellyfin for kodi addon does it. You can specify a different name in the settings dialog but it uses the device name by default. Might be worth taking inspiration from there if you're looking at implementing this

mcarlton00 commented 3 years ago

So, funny story. This is already possible to change via a value in the settings menu, and I didn't realize it existed until now.

That being said, I'm of the opinion that we should change the default value of it to automatically include the hostname. This appears to be being set the auth_string variable here: https://github.com/jellyfin/jellycon/blob/e3ec31ae99c3945f239a4ec256a552ada57804e5/resources/lib/downloadutils.py#L594-L600