search

jellyfin / jellyfin-android

Android Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
1.45k stars 240 forks source link

Volume and Brightness Controls cover content #1185

Open newhinton opened 1 year ago

newhinton commented 1 year ago

Describe the feature you'd like Currently, the swipe gesture for either brightness or volume create a rectangular box with an indicator in the middle of the screen. It would be nice if this indicator could be moved to the sides of the screen, so that the content will not be covered by using those controls.

Additional context LibreTube has a quite elegant solution, where the left side can be swiped for brighness-control, and on the right side a vertical bar shows up, indicating brightness. Volume is the same but inverted. (the bar has a little icon on the bottom and a numerical value on top to clarify)

Maxr1998 commented 1 year ago

I'm currently rewriting the player in compose, and while I mostly adopted the style from the previous player, I also made it a bit more transparent and changed the timeouts to be immediately after stopping the gesture. I'll see whether I can tweak the style a bit more. The split indicator that LibreTube does sounds interesting, but I currently don't know whether I want to implement it the same way.

bilogic commented 10 months ago

I would like to add that if the brightness is reduced to minimum (0%), it should switch to auto brightness.