jellyfin / jellyfin-android

Android Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
1.56k stars 251 forks source link

Screen rotation behaves weirdly and blocks back gesture #1212

Open newhinton opened 1 year ago

newhinton commented 1 year ago

Describe the bug

Integrated Player:

  1. Open any video
  2. Use the "fullscreen"-button in the bottom right to fix rotatiom
  3. Use back button/gesture

Now i would expect that the video closes and the last screen opens (main view or detail view of video)

However, what actually happens:

  1. App rotates back to vertical orientation
  2. Press back again
  3. App rotates back to horizontal
  4. Repeat

In my opinion, all the player-types should look and behave the same way. The web-one handles the back-button and rotation correctly, though it has not a good ui for mobile devices. The internal-one has a more mobile-friendly ux. (Is there a reason it is not the default choice?)

My proposed solution is to disable the button and vertical mode, the same way the web-player handles it. (It is also the same way many streaming-service-apps handle this)

Logs

No response

Application version

Version 2.6.0-beta.2

Where did you install the app from?

Sideloaded APK (libre build)

Device information

Pixel 7

Android version

GrapheneOS 14

Jellyfin server version

10.8.11

Which video player implementations does this bug apply to?

jellyfin-bot commented 8 months ago

This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments.

If you're the original submitter of this issue, please comment confirming if this issue still affects you in the latest release or master branch, or close the issue if it has been fixed. If you're another user also affected by this bug, please comment confirming so. Either action will remove the stale label.

This bot exists to prevent issues from becoming stale and forgotten. Jellyfin is always moving forward, and bugs are often fixed as side effects of other changes. We therefore ask that bug report authors remain vigilant about their issues to ensure they are closed if fixed, or re-confirmed - perhaps with fresh logs or reproduction examples - regularly. If you have any questions you can reach us on Matrix or Social Media.

newhinton commented 8 months ago

Please reconsider this stalebot. Just because noone had time to interact with this issue does not mean it is fixed. Or solved. Or beeing worked on. It is really annoying to write comments just to fight with a bot.

jellyfin-bot commented 4 months ago

This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments.

If you're the original submitter of this issue, please comment confirming if this issue still affects you in the latest release or master branch, or close the issue if it has been fixed. If you're another user also affected by this bug, please comment confirming so. Either action will remove the stale label.

This bot exists to prevent issues from becoming stale and forgotten. Jellyfin is always moving forward, and bugs are often fixed as side effects of other changes. We therefore ask that bug report authors remain vigilant about their issues to ensure they are closed if fixed, or re-confirmed - perhaps with fresh logs or reproduction examples - regularly. If you have any questions you can reach us on Matrix or Social Media.

newhinton commented 4 months ago

Please reconsider this stalebot. Just because noone had time to interact with this issue does not mean it is fixed. Or solved. Or beeing worked on. It is really annoying to write comments just to fight with a bot.

jellyfin-bot commented 3 weeks ago

This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments.

If you're the original submitter of this issue, please comment confirming if this issue still affects you in the latest release or master branch, or close the issue if it has been fixed. If you're another user also affected by this bug, please comment confirming so. Either action will remove the stale label.

This bot exists to prevent issues from becoming stale and forgotten. Jellyfin is always moving forward, and bugs are often fixed as side effects of other changes. We therefore ask that bug report authors remain vigilant about their issues to ensure they are closed if fixed, or re-confirmed - perhaps with fresh logs or reproduction examples - regularly. If you have any questions you can reach us on Matrix or Social Media.

newhinton commented 3 weeks ago

bump