jellyfin / jellyfin-android

Android Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
1.53k stars 248 forks source link

Unnecessary transcode because of mp2 audio #1281

Closed jellouser closed 1 week ago

jellouser commented 9 months ago

Describe the bug

  1. Play LiveTV TS stream with mp2 audio
  2. This results in Transcode (audio mp2 -> mp3, video copy) because of mp2 is not reported as supported audio codec.

The issue is fixed by "forcing" mp2 support in DeviceProfileBuilder

private val FORCED_AUDIO_CODECS = arrayOf(*PCM_CODECS, "alac", "aac", "ac3", "eac3", "dts", "mlp", "truehd", "mp2") <-- "mp2" added

Stream now plays DirectPlay (also requires DirectPlay fix https://github.com/jellyfin/jellyfin-android/issues/1277). I am not sure if there should be player-specific override or something, to make this ExoPlayer (and other supported players) only.

Logs

No response

Application version

2.6.0

Where did you install the app from?

Google Play

Device information

Samsung Galaxy S23

Android version

Android 13

Jellyfin server version

10.8.13

Which video player implementations does this bug apply to?

jellyfin-bot commented 5 months ago

This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments.

If you're the original submitter of this issue, please comment confirming if this issue still affects you in the latest release or master branch, or close the issue if it has been fixed. If you're another user also affected by this bug, please comment confirming so. Either action will remove the stale label.

This bot exists to prevent issues from becoming stale and forgotten. Jellyfin is always moving forward, and bugs are often fixed as side effects of other changes. We therefore ask that bug report authors remain vigilant about their issues to ensure they are closed if fixed, or re-confirmed - perhaps with fresh logs or reproduction examples - regularly. If you have any questions you can reach us on Matrix or Social Media.

huasbryan14 commented 5 months ago

The same thing happens in the web version, it does all the transcoding due to the mp2 format in the audio

jellyfin-bot commented 1 month ago

This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments.

If you're the original submitter of this issue, please comment confirming if this issue still affects you in the latest release or master branch, or close the issue if it has been fixed. If you're another user also affected by this bug, please comment confirming so. Either action will remove the stale label.

This bot exists to prevent issues from becoming stale and forgotten. Jellyfin is always moving forward, and bugs are often fixed as side effects of other changes. We therefore ask that bug report authors remain vigilant about their issues to ensure they are closed if fixed, or re-confirmed - perhaps with fresh logs or reproduction examples - regularly. If you have any questions you can reach us on Matrix or Social Media.