Closed anmoljhamb closed 7 months ago
I honestly have been using Jellyfin daily for a few months now, and I noticed this issue some time ago. I am personally not an android developer, so I don't know how much I'd be able to contribute to this issue. I'd appreciate any help! Thanks!
looks like it's technically not crashing- just calling dismissNotification()
with Constants.ACTION_STOP
regardless of whether or not you have the dismissable player notification option enabled. this doesn't seem to happen if you use the web player, and removing / commenting out Constants.ACTION_STOP -> viewModel.stop()
here prevents the player from stopping. not sure how the 'clear all notifications' works at the system level or if it's a jellyfin issue that's triggering the broadcast receiver.
this is just from a quick glance, i'm happy to look into this more.
The dismissible notification option only applies to the music player, so that part makes sense.
For the integrated video player, I wonder whether the notification should be dismissible at all, at least not when the playback is running. Then, dismissing all notifications wouldn't dismiss the persistent Jellyfin one and thus not stop the player.
removing / commenting out
Constants.ACTION_STOP -> viewModel.stop()
here prevents the player from stopping. not sure how the 'clear all notifications' works at the system level or if it's a jellyfin issue that's triggering the broadcast receiver.Great thanks for the start! I'll try that out, and see if it makes any difference! I will let you know as soon as I am able to. Thanks! @taitsmith
@Maxr1998 That makes sense to me! I'll look into it!
For the integrated video player, I wonder whether the notification should be dismissible at all, at least not when the playback is running. Then, dismissing all notifications wouldn't dismiss the persistent Jellyfin one and thus not stop the player.
i think preventing the notification from being dismissed during playback would make sense. i'll do some tinkering tomorrow on this.
Describe the bug
Issue
When attempting to clear all notifications within the Jellyfin application, the app consistently crashes.
Steps to Reproduce
Expected Behavior
The application should successfully clear all notifications without crashing and maintain stable functionality.
Actual Behavior
Upon selecting the option to clear all notifications, the Jellyfin application crashes abruptly.
Frequency
The issue occurs consistently every time the attempt is made to clear all notifications.
Screen Recording
https://github.com/jellyfin/jellyfin-android/assets/105477755/38872ea0-db57-4b65-850f-6a0e767b3a63
Logs
Application version
2.6.0
Where did you install the app from?
Google Play
Device information
Redmi Note 11S
Android version
Android V13
Jellyfin server version
10.8.13
Which video player implementations does this bug apply to?