search

jellyfin / jellyfin-android

Android Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
1.57k stars 251 forks source link

Forcing subtitle burning does not work on web player #1464

Closed paulzzh closed 2 months ago

paulzzh commented 3 months ago

Describe the bug

  1. Go to Settings
  2. Click on Subtitles
  3. Choose All in Burn subtitles
  4. Scroll down and click Save
  5. Play a video
  6. Subtitles are rendered on the client side and messed up the fonts
  7. This option works on the Integrated player
  8. This option works in a real web browser

Logs

No response

Application version

latest branch master, commit 7805cec

Where did you install the app from?

Sideloaded APK (proprietary build)

Device information

Oneplus 7T

Android version

Android 14, PixelOS Unofficial

Jellyfin server version

10.9.9

Which video player implementations does this bug apply to?

paulzzh commented 3 months ago

Android web player always POST SubtitleProfiles with SSA/ASS supported When set Burn subtitles to All, it should be empty [] image

paulzzh commented 3 months ago

They come from nativeshell.js Before getDeviceProfile is called, SubtitleProfiles is empty. https://github.com/jellyfin/jellyfin-android/blob/0d1b3790a8ab4df7df9a57732a52c084aabac31a/app/src/main/assets/native/nativeshell.js#L98-L116

After setting SubtitleProfiles to [] from the debugger, I got the encoded subtitles. image

paulzzh commented 3 months ago

related 9513041 #421 #440 Set Burn subtitles to Auto and there are already values in SubtitleProfiles Perhaps we don't need to modify this value. image

solidsnake1298 commented 3 months ago

Another user and I are having this issue with the integrated player with PGS subs.