jellyfin / jellyfin-android

Android Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
1.34k stars 224 forks source link

Mistranslation/Readability of Battery Optimization Message #257

Open Zunawe opened 3 years ago

Zunawe commented 3 years ago

In this message in Italian: https://github.com/jellyfin/jellyfin-android/blob/f03a6f5efab51d7398167b5cc9138499909a5bd3/app/src/main/res/values-it/strings.xml#L8 the word battera should be spelled batteria. Haven't looked into the localization process here except to find out that you use an automated tool, so I didn't want to make a PR.

In the same message, the sentence is too long for the banner and gets cut off with no way to expand it and read the whole thing. The rest of the message is easy enough to guess, but it could theoretically be a problem in languages even less related to or more verbose than English, or with other messages that use the same UI element.

(Device is a OnePlus 6T)

Not an urgently needed fix, but should still be addressed eventually.

Maxr1998 commented 3 years ago

I just fixed the typo on our translation page here, thanks for spotting it! Regarding the message length/ellipsis, I'd need to look at the code. However, I think the Material Design spec recommends to keep Snackbar messages reasonably short (1-2 lines), so maybe it'd be preferable to update the translation instead. Maybe you can come up with a shorter version?

Zunawe commented 3 years ago

Unfortunately I'm not a fluent Italian speaker, so I don't personally feel qualified to rewrite the message. Knowing that, the only way I can think to shorten it is to remove quando lo schermo è spento, which means "when the screen is off". Otherwise, I don't really know.

jellyfin-bot commented 2 years ago

This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments.

If you're the original submitter of this issue, please comment confirming if this issue still affects you in the latest release or master branch, or close the issue if it has been fixed. If you're another user also affected by this bug, please comment confirming so. Either action will remove the stale label.

This bot exists to prevent issues from becoming stale and forgotten. Jellyfin is always moving forward, and bugs are often fixed as side effects of other changes. We therefore ask that bug report authors remain vigilant about their issues to ensure they are closed if fixed, or re-confirmed - perhaps with fresh logs or reproduction examples - regularly. If you have any questions you can reach us on Matrix or Social Media.

Zunawe commented 2 years ago

No change has been made to shorten the message. But I think more importantly, there hasn't really been a discussion about what to do in general about something like this.

I clicked through a few languages that use Latin characters and there were quite a few where this string is problematic. And it's not the only snackbar string with too many characters either.

I understand this is a nitpicky, low priority issue since realistically most users will be able to infer the meaning of most snackbar messages even when the end is cut off. So I don't mind this issue sitting in limbo. But it's still a usability issue with no workaround that makes the experience worse if you don't use the English version of the app. So I'd like to keep it open at least until some part of the translation process is affected.

Seems like character limits can be modified in Weblate. That's probably the best bet for this case if it's possible. But I haven't done the research to know for sure.