search

jellyfin / jellyfin-android

Android Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
1.35k stars 225 forks source link

Show more information about the content played in the exoplayer player. #60

Open JulioNahum opened 3 years ago

JulioNahum commented 3 years ago

Incorporate the logo of the movie or series in the upper left part of the player and an arrow to go back. Also 40 seconds before the end of a chapter of a series, enter the button for the next chapter.

Emby player example:

https://imgur.com/8cP6v7E

nielsvanvelzen commented 3 years ago

You have a back arrow in your operating system, why do you want one in the player too?

JulioNahum commented 3 years ago

Oh, it was just a suggestion. I think it is too much since the operating system also has an arrow. Sorry for that information. However, I hope the other suggestions are a little better seen. To give more "elegance to the player"

Maxr1998 commented 3 years ago

I'm personally not a fan of adding a logo, as it might look out of place next to the title, and because most media often doesn't have one. Also, iirc, the poster/logo might even be removed from the web player in the future - see jellyfin/jellyfin-web#1825.

JulioNahum commented 3 years ago

I'm personally not a fan of adding a logo, as it might look out of place next to the title, and because most media often doesn't have one. Also, iirc, the poster/logo might even be removed from the web player in the future - see jellyfin/jellyfin-web#1825.

The new Jellyfin application for Android does not have that player. You now have the Exoplayer and you have to activate it. It is in experimental mode but it works quite well. It seems to me that the web player was left aside to take advantage of the exoplayer. See how the new player looks and tell me if it would not be good where the arrow is, change it to the logo of what you are looking at.

https://imgur.com/9qJoS6z

Maxr1998 commented 3 years ago

I know the ExoPlayer integration, I developed it, lol. That's why I was making my point. ^^

heyhippari commented 3 years ago

I'm personally not a fan of adding a logo, as it might look out of place next to the title, and because most media often doesn't have one. Also, iirc, the poster/logo might even be removed from the web player in the future - see jellyfin/jellyfin-web#1825.

It was removed before that, actually. It's been removed since 10.6.0.

We're generally not fans of logos in most situations either. I have been thinking of a toggle to disable them by default on the details page as well.

eglia commented 3 years ago

You have a back arrow in your operating system, why do you want one in the player too?

85

Because the OS back button does not work after returning from picture in picture.

Maxr1998 commented 3 years ago

You have a back arrow in your operating system, why do you want one in the player too?

85

Because the OS back button does not work after returning from picture in picture.

That wouldn't be fixed by an integrated back button though. However, rewriting the app to use fragments and a single activity would, and that's already planned. I just didn't have time to work on it lately.

foux commented 1 year ago

You have an OS back button only if you’ve kept Android buttons. With android gesture navigations, the back arrow would be a nice addition. And we have it on the integrated player, so why not on the native one?

Concerning artwork I totally agree that it would be nice to have them