search

jellyfin / jellyfin-androidtv

Android TV Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
2.87k stars 489 forks source link

Android TV app issue with resume on grouped versions #1849

Open mattmarsden1978 opened 2 years ago

mattmarsden1978 commented 2 years ago

Describe the bug

If I have 2 versions of the same movie grouped together e.g. 4K and 3D versions - one of the vesions won't save the resume point. I can see it when I stop the movie and it goes to the movie info screen but when I go off that and back on it theres no resume point. If I play the other version of the movie it saves the resume point. Can this be fixed? Thanks

I think this is a bug as it works properly on the web version.

Logs

No response

Application version

0.13

Where did you install the app from?

Sideloaded APK

Device information

Zidoo

Android version

Android 9

Jellyfin server version

10.8.1

mattmarsden1978 commented 2 years ago

Sorry to be a pain - do you know if this will be looked at as the web version works fine with resuming at the same point from grouped files, just the Android TV version that doesn't. Thanks very much.

Andy2244 commented 2 years ago

Just to confirm the wanted logic or what the webclient does. So all versions, including the main should share the same resume point? So if you watch the 3d version and switch to any other, it should resume from the 3d versions resume point?

PS: I also noticed there is no visual feedback which version is selected? I see no changes at all in the details view? I guess this should also be fixed.

mattmarsden1978 commented 2 years ago

Yes, the same logic as the webclient - all versions resume from the same point, and yes to the PS

Andy2244 commented 2 years ago

@nielsvanvelzen fixed in my fork and will setup a PR next week

Janhouse commented 11 months ago

@nielsvanvelzen fixed in my fork and will setup a PR next week

Did you make the PR?

Andy2244 commented 11 months ago

Did you make the PR?

no, but should be a change i can upstream after i have a clean "lite" version working and than slowly splitting out worthwhile changes to upstream. Realistically will try up-streaming some of my changes early next year. Just started working on stuff again.