search

jellyfin / jellyfin-androidtv

Android TV Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
2.69k stars 459 forks source link

Player overlay discussion #257

Closed Florianisme closed 4 years ago

Florianisme commented 4 years ago

Moving to an issue to keep the PR #251 clean.

Florianisme commented 4 years ago

Is there no button to switch to the next channel? Also, that three dot button doesn't seem to look that nice, isn't the material icon different than that?

Originally posted by @dkanada in https://github.com/jellyfin/jellyfin-androidtv/pull/251#issuecomment-571118439

No there is no button for that (yet). Regarding the channel quick switcher button, I havent found a better icon but if you've got one let me know.

dkanada commented 4 years ago

How about this one?

dkanada commented 4 years ago

I also think the three dot button should probably be at the end if it just pulls up a menu.

Florianisme commented 4 years ago

No, it's not that type of a menu (like the menus on an Android phone when you click the three dot button in an app) It's more like a pop up at the bottom, I'll post a screenshot when I get home.

Florianisme commented 4 years ago

This is what it looks like (ignore the small text overlap, that might've been there before) Screenshot_1578330475 I've set up "Bloomberg" as an example on the right, it shows the stations name and current program

daullmer commented 4 years ago

I think adding the Logo of the current movie/tv series would look great

Florianisme commented 4 years ago

I think so aswell but @nielsvanvelzen was against it. I dont know, maybe we can have a poll or something :smile:. Or the team members decide about it

nielsvanvelzen commented 4 years ago

More customization preferences!!

I find the poster annoying if it's as big as the current player. I do like the logo (top-right).

edit: As @Ullmie02 pointed out, it might have been the top-left it's currently showing at

daullmer commented 4 years ago

I thought of top left because the clock is at the top right

AndreasGB commented 4 years ago

I would also prefer a customizable approach, the clock and user display should be optional as well imo

thornbill commented 4 years ago

Personally I don’t mind having the logo (it adds something visually I think), but I agree that in the current layout it was too large.

Florianisme commented 4 years ago

This is what it looks like in the new layout.. Its even bigger

Screenshot_1578340136

I don't know how flexible this leanback layout is in terms of customizing it but maybe we can shrink it a bit

nielsvanvelzen commented 4 years ago

The current layout looks like this, I added very nicely made captions to clarify which image is the logo and which is the poster.

image

The logo is not really a problem, it's in a location where subtitles normally wouldn't show and logos have transparent backgrounds. The poster doesn't have a transparent background, is on the bottom of the screen (where subtitles with long lines could show) and is quite large.

In your latest screenshot it looks way too large for me. In my opinion the controls should assist while watching instead of obstructing the whole video.

Florianisme commented 4 years ago

Solid point! Yes I got confused with the logo and the poster. So my suggestion is that I'll remove the poster and the long description again and instead just add the logo.

dkanada commented 4 years ago

Aww I liked the new poster and description! Oh well, it's a huge improvement regardless.

Florianisme commented 4 years ago

This discussion screams for a lot more customization options They'll go into another PR though

mueslimak3r commented 2 years ago

I've been digging through commits to locate where issue #1101 arose. Why does the leanback seekbar always get focus when "pause" is clicked, and not the "playPause" button?