search

jellyfin / jellyfin-androidtv

Android TV Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
2.77k stars 471 forks source link

Playback Controls Enhancement #323

Closed Artiume closed 2 years ago

Artiume commented 4 years ago

Currently on the Fire Stick (not sure for other atv devices), if you click the center action button, it will pause the video stream. If you click left or right, it brings up the menu.

Could we change it to where the center action button brings up the menu (so double click to pause), left and right respectively skip back and forward.

nielsvanvelzen commented 4 years ago

Did you test this with #251?

Florianisme commented 4 years ago

That isn't implemented in my PR I think. At least I haven't tried it yet

nielsvanvelzen commented 4 years ago

Hmm.. On my remote the left and right buttons on the dpad will seek the video while up & down show/hide the controls (in the old overlay).

I just looked at the code and there is literally a statement that disables that functionality for FireTV..

https://github.com/jellyfin/jellyfin-androidtv/blob/master/app/src/main/java/org/jellyfin/androidtv/playback/CustomPlaybackOverlayFragment.java#L656

Artiume commented 4 years ago

Did you test this with #251?

No, not yet. I haven't tested building the other clients yet, just the main web ui. What's the time line looking for 251 being implemented? I can hold back UI feedback if the current layout is deprecating soon.

I just looked at the code and there is literally a statement that disables that functionality for FireTV..

Haha, why is that there? So I was looking at the rest of that code, L665, do you think that we should that pull from server instead of being hard-coded?

nielsvanvelzen commented 4 years ago

What's the time line looking for 251 being implemented?

We're aiming to merge #251 very soon and release it in the next update (0.12) together with a lot of other UI updates.

I can hold back UI feedback if the current layout is deprecating soon.

Feel free to comment on the open PR's that contain screenshots

Haha, why is that there?

¯\(ツ)/¯

So I was looking at the rest of that code, L665, do you think that we should that pull from server instead of being hard-coded?

What exactly do you want to pull from the server?

Artiume commented 4 years ago

I could've sworn there was a setting in the dashboard that allowed you to control it but I can't find it. it might be in AndroidTV that I'm thinking of. Default had skip back of 10 seconds and skip forward was 30 seconds.

nielsvanvelzen commented 4 years ago

I found it under user settings -> "Playback" in the web client. Might be worth adding at some point, but that's a separate issue.

Artiume commented 4 years ago

Yeah could make it the global across everything and then allow you to customize the times for each device/device type. Just food for thought

mueslimak3r commented 2 years ago

should be fixed by:

1291

1207

nielsvanvelzen commented 2 years ago

Closing as fixed, please let us know if you're still experiencing this issue.