jellyfin / jellyfin-androidtv

Android TV Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
2.61k stars 452 forks source link

Add support for Jellyfin SyncPlay #538

Open gittes opened 4 years ago

gittes commented 4 years ago

It would be awesome especially with the recent events if SyncPlay (introduced recently with Jellyfin 10.6.x) worked for the Jellyfin AndroidTV client.

It would be also cool as a slight enhancement if the this implementation leveraged variable playback speeds to catchup when out of sync by only a few seconds or less instead of hard skipping and/or have the ability to define a offset tolerance before making an adjustment in seeking.

I'll let you guys figure out the interface design; would just love to have it.

It would just be nice to have SyncPlay on the big TV while using another device to chat or video conference with people instead of only watching SyncPlay groups in the web interface.

Some more superfluous suggestions: Perhaps existing SyncPlay groups could be presented as a channel/category/section similar to "Continue Playing" listed items with a "Now watching with others" section in the Home screen in addition to a group list browser. And there can be a "play with new SyncPlay" button next to the play button to initiate new SyncPlay group in the media item description screen.

nielsvanvelzen commented 4 years ago

We'd like to add SyncPlay too! It will take some time though. SyncPlay requires some changes in the apiclient which is undergoing a big refactor right now. After that's done we can start integrating SyncPlay.

gittes commented 4 years ago

We'd like to add SyncPlay too! It will take some time though. SyncPlay requires some changes in the apiclient which is undergoing a big refactor right now. After that's done we can start integrating SyncPlay.

Fair enough and understood. I'll wait patiently and I am eager to see what the refactoring brings.

Thank you for setting expectations and the response.

bqv commented 3 years ago

What's the story folks?

nielsvanvelzen commented 3 years ago

Current state of the apiclient: waiting for 10.7 to release (minimum supported version) and then we can start integrating it into the app, that will take some time though. When the integration is done we're rewriting all video/audio playback code and after that's done SyncPlay could be implemented. So it will take quite some time.

GlassedSilver commented 3 years ago

Which issues could I track to see how things progress? I searched for API as open issues, but there was nothing that seemed relevant. Maybe I should have searched differently?

nielsvanvelzen commented 3 years ago

The new apiclient (now called Jellyfin Kotlin SDK) is now in beta (since a few days). We will be testing it in the mobile android app before migrating the Android TV app. SyncPlay is something that will be added as part of the playback rewrite (which is still in early stages and there is no issue for it).

edit: I should add, SyncPlay won't be added until the API is stable. Right now the syncplay api is changing each release and breaks existing integrations (like jellyfin-desktop). So it might be 10.8 or even 10.9 to at least consider adding it.

Siress commented 2 years ago

Been a while. Any updates to this over the past year?

Loving the work everyone has done here... syncplay maybe the feature that pushes my wife over the edge of adoption since we use that around the house every day.

nielsvanvelzen commented 2 years ago

SyncPlay is a part of #1057, which is slowly progressing.

JadeilsonSantos commented 1 year ago

Good morning everybody! any news?

AnimalLover2143 commented 3 weeks ago

this would really help lets say your at your computer and your family will be using the tv to watch a movie but groups isnt there but if it was you could watch with everyone.