search

jellyfin / jellyfin-apiclient-python

Python API Client for Jellyfin
GNU General Public License v3.0
91 stars 31 forks source link

Media folder api #39

Closed Erotemic closed 8 months ago

Erotemic commented 9 months ago

This is a small part of https://github.com/jellyfin/jellyfin-apiclient-python/pull/11 I'm interested in using. I made a small change on top to accept a suggestion made in that discussion and I renamed "scan library" to "refresh library" to be consistent with the API names.

I attempted to keep the original author as part of the commit, but it looks like that didn't work. Not sure if there is a good way to give credit there.

s-t-e-v-e-n-k commented 8 months ago

In this case, I like to put:

Co-Authored-By: John Doe <john@example.com>

at the bottom of the commit message so they get credit if I was only inspired by their idea.

Erotemic commented 8 months ago

@s-t-e-v-e-n-k TIL, thanks. For my (and others) reference, adding such a line to a commit message is supported by github. It doesn't seem to reflect anything special in the git log itself (except for the text), but that's ok. It's at least clear that @qishen was involved.

This should now be ready for review / merge.