jellyfin / jellyfin-chromecast

Chromecast Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
137 stars 43 forks source link

Cast receiver shouldn't be limited to Home devices #603

Open GodTamIt opened 2 months ago

GodTamIt commented 2 months ago

Describe the bug

The code in castDevices.ts and codecSupportHelper.ts make the assumption that the receiving device is one of the Home devices (i.e. GEN1AND2, AUDIO, GEN3, ULTRA, NESTHUBANDMAX, CCGTV). I don't think this is a valid assumption because any Android TV could be a web cast receiver. At least with the latest stable testing, it seems that way on my Android TV. Unless I'm mistaken, this is because the Jellyfin Android TV application hasn't implemented Cast Connect.

Additional context

I used to work on some of these devices 🙃

IDisposable commented 2 weeks ago

Starting to work on this. Cleaning up the device detection first. https://github.com/IDisposable/jellyfin-chromecast/tree/add-generic-android

3flex commented 5 days ago

I've been thinking about ways to do this too.

Instead of trying to identify specific device types I think it would be better to dynamically check for required support for resolution, codecs, profiles and levels and build the device profile from there.

For example, instead of trying to identify a specific Cast device then deciding that it supports 720p, 1080p or 4k based on published specs, just check for the resolution via canDisplayType. That way the check should work regardless of device type.

IDisposable commented 5 days ago

Couldn't agree more, taking a baby step upright now.