jellyfin / jellyfin-expo

Jellyfin Mobile for iOS
https://jellyfin.org
Mozilla Public License 2.0
318 stars 68 forks source link

Update url handling #313

Closed thornbill closed 3 years ago

thornbill commented 3 years ago

Uses the normalize-url package for normalizing user entered urls and adds polyfill for standard URL globals that are not available in react-native. This mirrors the approach I have used in the TypeScript SDK.

Depends on #312

codecov[bot] commented 3 years ago

Codecov Report

Merging #313 (4994104) into master (c97dda0) will decrease coverage by 0.37%. The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #313      +/-   ##
==========================================
- Coverage   33.19%   32.81%   -0.38%     
==========================================
  Files          37       37              
  Lines         705      704       -1     
  Branches      139      138       -1     
==========================================
- Hits          234      231       -3     
- Misses        425      426       +1     
- Partials       46       47       +1     
Impacted Files Coverage Δ
App.js 0.00% <ø> (ø)
stores/ServerStore.js 78.57% <0.00%> (-13.10%) :arrow_down:
utils/ServerValidator.js 96.36% <100.00%> (-0.19%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c97dda0...4994104. Read the comment docs.

thornbill commented 3 years ago

I just noticed this fails to migrate old servers. ~Tagging as blocked until it is resolved.~

This has been updated to handle the migration now.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication