search

jellyfin / jellyfin-expo

Jellyfin Mobile for iOS
https://jellyfin.org
Mozilla Public License 2.0
304 stars 66 forks source link

Move header control to screens #328

Closed thornbill closed 2 years ago

thornbill commented 2 years ago

This allows the header to be controlled at the screen level, which should allow for custom controls to be added on individual screens (i.e. an edit button in the header). I do not think this worked correctly on old versions of react navigation.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

codecov[bot] commented 2 years ago

Codecov Report

Merging #328 (2d54f25) into master (5ce2c13) will decrease coverage by 0.05%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #328      +/-   ##
==========================================
- Coverage   37.77%   37.72%   -0.06%     
==========================================
  Files          39       39              
  Lines         720      721       +1     
  Branches      144      144              
==========================================
  Hits          272      272              
- Misses        402      403       +1     
  Partials       46       46
Impacted Files Coverage Δ
navigation/AppNavigator.js 0.00% <ø> (ø)
navigation/SettingsNavigator.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5ce2c13...2d54f25. Read the comment docs.