jellyfin / jellyfin-expo

Jellyfin Mobile for iOS
https://jellyfin.org
Mozilla Public License 2.0
304 stars 66 forks source link

Add eslint rules for sonarqube issues #349

Closed thornbill closed 2 years ago

thornbill commented 2 years ago

Adds some additional eslint rules for things that sonarqube flags as code smells.

Refs: https://github.com/jellyfin/jellyfin-web/issues/3494

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.4% 1.4% Duplication

codecov[bot] commented 2 years ago

Codecov Report

Merging #349 (8bdd047) into master (807396d) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #349   +/-   ##
=======================================
  Coverage   48.68%   48.68%           
=======================================
  Files          39       39           
  Lines         725      725           
  Branches      145      145           
=======================================
  Hits          353      353           
  Misses        335      335           
  Partials       37       37           

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more