jellyfin / jellyfin-expo

Jellyfin Mobile for iOS
https://jellyfin.org
Mozilla Public License 2.0
288 stars 64 forks source link

Can't go fullscreen on external monitor #426

Open Cyberbeni opened 1 year ago

Cyberbeni commented 1 year ago

Describe the bug

M1 and better iPads support external monitors since iOS 16. Apps that support split screen can go full screen on the external monitor, other apps will be just displayed in the middle with the same size as the iPad's display.

System (please complete the following information):

Additional context

This value needs to be removed or set to false in the info.plist: https://developer.apple.com/documentation/bundleresources/information_property_list/uirequiresfullscreen

I'm currently without a Mac for like 3 more weeks, I'll submit a PR once I can try it out myself if nobody else picks it up until then.

Cyberbeni commented 1 year ago

I couldn't test it because the Expo Go app supports split-screen anyways and expo-cli build:ios says this:

expo build:ios has been superseded by eas build. Learn more.

Run the following:

› npm install -g eas-cli
› eas build -p ios

expo build:ios has been discontinued (January 4, 2023).

Request failed with status code 404

If I try to run npm install eas-cli --save-dev then I get an ERESOLVE error.

Cyberbeni commented 1 year ago

According to this, the default has changed in SDK 43 to allow split screen but the latest Jellyfin app uses 43 and doesn't seem to have it disabled. 🤔

Cyberbeni commented 1 year ago

Or maybe because app.json doesn't specify the SDK version and they forgot to uncomment that check, it would still default to full screen only?