search

jellyfin / jellyfin-expo

Jellyfin Mobile for iOS
https://jellyfin.org
Mozilla Public License 2.0
288 stars 64 forks source link

Newer Expo SDK #462

Closed thiswallz closed 1 month ago

thiswallz commented 9 months ago

Seems this app is using sdk 46 which causes a lot of issues for trying and building for expo, since is already deprecated, is there something we can do to use a newer one?

thanks!

thornbill commented 9 months ago

Unfortunately Expo 46 was the last version to support classic builds so we need to figure out a path forward for publishing builds without subscribing to expo's build service... but we should still upgrade. It's really just a matter of having the time to do it. It's not unusual for a couple things to break but their upgrade notes normally document anything breaking pretty well.

DrNgo commented 4 months ago

@thornbill i'm in the process of upgrading expo to 50 and changing the deployment of the app to build using github actions and submit it to testflight for testing. Let me know if there's something specific You want me to do regarding these steps

thornbill commented 4 months ago

The help would definitely be appreciated @DrNgo. My preference would be for one PR per Expo version like this for example. I did attempt to make a GH Action for builds previously but it did not work. Also it wasn't clear in your comment but please do not publish a TestFlight build under your own account. Anthony manages publishing all of our official apps and I'm not sure if that would impede our official version.

ebg1223 commented 4 months ago

@thornbill @DrNgo i work in rn / expo daily. Happy to help with this if someone has a WIP. Have lots of example deployments I can pull from

thornbill commented 1 month ago

Closing this one in favor of https://github.com/jellyfin/jellyfin-expo/issues/492 with links to the release notes.