search

jellyfin / jellyfin-ffmpeg

FFmpeg for Jellyfin
https://jellyfin.org
Other
478 stars 127 forks source link

Refactor Dockerfiles #329

Closed Gauvino closed 7 months ago

Gauvino commented 8 months ago

Refactor dockerfiles for better syntax and removed unused package

nyanmisaka commented 8 months ago

Please rebase the PR.

Gauvino commented 8 months ago

@nyanmisaka why is all the building failing cause I don’t think the problem is coming from my PR or I missed something maybe I'm gonna look further when I'm home cause right now I don't have a pc for the week

nyanmisaka commented 8 months ago

@nyanmisaka why is all the building failing cause I don’t think the problem is coming from my PR or I missed something maybe I'm gonna look further when I'm home cause right now I don't have a pc for the week

I can build locally without your PR. Please check it on your side. I'll come back to this next time.

Gauvino commented 8 months ago

Your building with the script ? What command do you use ?

nyanmisaka commented 8 months ago 
./build focal arm64
Gauvino commented 8 months ago

I tried to build everything with different platform and the only problem I see was apt-transport-http being removed

Gauvino commented 7 months ago

@nyanmisaka Does this PR need changed or do you have a problem with it ?

If it is let me know it!

nyanmisaka commented 7 months ago

@nyanmisaka Does this PR need changed or do you have a problem with it ?

If it is let me know it!

I will take some time to test and will give you the results later.

Gauvino commented 7 months ago

@nyanmisaka Does this PR need changed or do you have a problem with it ?

If it is let me know it!

I will take some time to test and will give you the results later.

Could you at least approval the action check to see if it's building correctly please

Gauvino commented 7 months ago

Still failing don’t really know why but I will check when I’m back home

Gauvino commented 7 months ago

Could you please approval the action please @nyanmisaka

Gauvino commented 7 months ago

Another time could you please ! @nyanmisaka