jellyfin / jellyfin-kodi

Jellyfin Plugin for Kodi
https://jellyfin.org
GNU General Public License v3.0
858 stars 113 forks source link

Unable to play BDMV/DVD files #33

Closed yangtfu closed 4 years ago

yangtfu commented 5 years ago

all my bdmv files cannot be played by jellyfin plugin, but they can be played via smb path. This is the same problem i'm facing: https://emby.media/community/index.php?/topic/68437-bdmv-rips-not-playing-on-emby-402-with-embykodi-beta-add-on/

Does anyone know if it's a bug or configuration issue?

oddstr13 commented 5 years ago

I don't have any bdmv to test with. Does it play in the web interface? If not, it's an issue for the server https://github.com/jellyfin/jellyfin/issues If it does play in web, but not Kodi, that at least narrows down the possibilities some.

I'd suggest remuxing to mkv, but that's probably not practical or desirable for you.

yangtfu commented 5 years ago

I don't have any bdmv to test with. Does it play in the web interface? If not, it's an issue for the server https://github.com/jellyfin/jellyfin/issues If it does play in web, but not Kodi, that at least narrows down the possibilities some.

I'd suggest remuxing to mkv, but that's probably not practical or desirable for you.

It works in the web interface. Plus, i'm using kodi native play method in the add-on settings. And it works if i play index.bdmv directly from file path but not in jellyfin scraped items, so i think it's a plugin path parsing issue.

holow29 commented 4 years ago

Can replicate; here is my log (copied from #327 )

2020-06-16 10:47:17.631 T:15525 NOTICE: VideoPlayer::OpenFile: nfs://192.168.1.142/volume1/films/Bluray/Woodstock (1970) 2020-06-16 10:47:17.632 T:15596 NOTICE: Creating InputStream 2020-06-16 10:47:17.648 T:15596 NOTICE: Creating Demuxer 2020-06-16 10:47:17.650 T:15596 ERROR: Read - Error( -14, read call failed with "<0x15>" ) 2020-06-16 10:47:17.650 T:15596 ERROR: Open - error probing input format, nfs://192.168.1.142/volume1/films/Bluray/Woodstock (1970) 2020-06-16 10:47:17.650 T:15596 ERROR: OpenDemuxStream - Error creating demuxer 2020-06-16 10:47:17.650 T:15596 NOTICE: CVideoPlayer::OnExit() 2020-06-16 10:47:17.652 T:15596 ERROR: Failed to close(volume1/films/Bluray/Woodstock (1970)) - close call failed with "NFS: Commit failed with NFS3ERR_ISDIR(-21)" 2020-06-16 10:47:17.659 T:15577 ERROR: EXCEPTION: XBMC is not playing any file 2020-06-16 10:47:17.741 T:15525 ERROR: Previous line repeats 1 times. 2020-06-16 10:47:17.741 T:15525 NOTICE: CVideoPlayer::CloseFile() 2020-06-16 10:47:17.743 T:15525 NOTICE: VideoPlayer: waiting for threads to exit 2020-06-16 10:47:17.743 T:15525 NOTICE: VideoPlayer: finished waiting 2020-06-16 10:47:17.765 T:15577 NOTICE: JELLYFIN.monitor -> DEBUG::jellyfin_kodi/monitor.py:100 [ xbmc: Player.OnPlay ] { "item": { "type": "unknown" }, "player": { "playerid": -1, "speed": 1 } } 2020-06-16 10:47:17.770 T:15577 NOTICE: JELLYFIN.objects.actions -> DEBUG::jellyfin_kodi/objects/actions.py:780 Invalid playstate update 2020-06-16 10:47:17.878 T:15577 NOTICE: JELLYFIN.helper.utils -> DEBUG::jellyfin_kodi/helper/utils.py:47 --[ window clear: jellyfin_play ]

YK-Samgo commented 4 years ago

I think I've fixed the issue, and submit a pull request #330 . But I need someone else to test the code, and can you do me a favor?

holow29 commented 4 years ago

I can't test it right now (not at my setup) unfortunately. You might consider adding a similar function (or re-using) for DVDs to point to VIDEO_TS.IFO inside VIDEO_TS folder. (Such as /folder/Casino Royale (DVD)/VIDEO_TS/VIDEO_TS.IFO)

YK-Samgo commented 4 years ago

I added the support for DVD folders in exactly the same way, and pushed it to another branch https://github.com/YK-Samgo/jellyfin-kodi/tree/DVDripSupport @holow29 Could you please have it tested? And I will submit another pull request after confirming the function. Thanks.

YK-Samgo commented 4 years ago

By the way, you can see the target file in kodi by right click on the movie/long press OK on a romote control/ X with a Xbox controller -> Information -> Refresh.

holow29 commented 4 years ago

Sorry for taking so long to respond. Finally made it back to my setup. Blu-rays and DVDs are playing perfectly if they are in my Movies library. Thank you @YK-Samgo for the fix! They don't seem to work in my TV Shows library...need to investigate why that is.

holow29 commented 4 years ago

I'm getting the same issue I used to get for Movies on TVShows: Kodi seems to be trying to open the directory instead of a file for TV Shows. I will look and see if I can port YK-Samgo's fix for TV Shows as well, but if anyone beats me to it, that would be fine as well haha (Edit: Attemped here https://github.com/jellyfin/jellyfin-kodi/pull/384)

yswtrue commented 2 years ago

It still can't play bdmv folder like this dir struct

rock@rockpi-4cplus:/mnt/downloads/Striptease.1996.MULTi.COMPLETE.BLURAY-GerHD$ tree
.
├── BDMV
│   ├── BACKUP
│   │   ├── CLIPINF
│   │   │   ├── 00000.clpi
│   │   │   ├── 00002.clpi
│   │   │   ├── 00003.clpi
│   │   │   ├── 00004.clpi
│   │   │   ├── 00005.clpi
│   │   │   ├── 00006.clpi
│   │   │   ├── 00007.clpi
│   │   │   ├── 00008.clpi
│   │   │   ├── 00009.clpi
│   │   │   ├── 00010.clpi
│   │   │   ├── 00011.clpi
│   │   │   ├── 00012.clpi
│   │   │   ├── 00013.clpi
│   │   │   ├── 00014.clpi
│   │   │   ├── 00015.clpi
│   │   │   ├── 00016.clpi
│   │   │   ├── 00017.clpi
│   │   │   ├── 00018.clpi
│   │   │   ├── 00019.clpi
│   │   │   ├── 00020.clpi
│   │   │   ├── 00021.clpi
│   │   │   ├── 00022.clpi
│   │   │   ├── 00024.clpi
│   │   │   ├── 00025.clpi
│   │   │   ├── 00026.clpi
│   │   │   ├── 00027.clpi
│   │   │   ├── 00028.clpi
│   │   │   ├── 00029.clpi
│   │   │   ├── 00030.clpi
│   │   │   ├── 00031.clpi
│   │   │   ├── 00032.clpi
│   │   │   ├── 00033.clpi
│   │   │   ├── 00034.clpi
│   │   │   ├── 00035.clpi
│   │   │   ├── 00036.clpi
│   │   │   ├── 00037.clpi
│   │   │   ├── 00038.clpi
│   │   │   ├── 00039.clpi
│   │   │   ├── 00041.clpi
│   │   │   ├── 00042.clpi
│   │   │   ├── 00043.clpi
│   │   │   ├── 00044.clpi
│   │   │   ├── 00045.clpi
│   │   │   ├── 00046.clpi
│   │   │   ├── 00047.clpi
│   │   │   ├── 00048.clpi
│   │   │   ├── 00049.clpi
│   │   │   ├── 00050.clpi
│   │   │   ├── 00051.clpi
│   │   │   ├── 00052.clpi
│   │   │   ├── 00053.clpi
│   │   │   ├── 00058.clpi
│   │   │   ├── 00059.clpi
│   │   │   ├── 00060.clpi
│   │   │   ├── 00061.clpi
│   │   │   ├── 00062.clpi
│   │   │   ├── 00063.clpi
│   │   │   └── 00069.clpi
│   │   ├── MovieObject.bdmv
│   │   ├── PLAYLIST
│   │   │   ├── 00011.mpls
│   │   │   ├── 00012.mpls
│   │   │   ├── 00013.mpls
│   │   │   ├── 00014.mpls
│   │   │   ├── 00015.mpls
│   │   │   ├── 00016.mpls
│   │   │   ├── 00017.mpls
│   │   │   ├── 00018.mpls
│   │   │   ├── 00022.mpls
│   │   │   ├── 00023.mpls
│   │   │   ├── 00024.mpls
│   │   │   ├── 00025.mpls
│   │   │   ├── 00026.mpls
│   │   │   ├── 00027.mpls
│   │   │   ├── 00028.mpls
│   │   │   ├── 00031.mpls
│   │   │   ├── 00032.mpls
│   │   │   ├── 00033.mpls
│   │   │   ├── 00034.mpls
│   │   │   ├── 00035.mpls
│   │   │   ├── 00036.mpls
│   │   │   ├── 00038.mpls
│   │   │   ├── 00039.mpls
│   │   │   ├── 00040.mpls
│   │   │   ├── 00041.mpls
│   │   │   ├── 00042.mpls
│   │   │   ├── 00043.mpls
│   │   │   ├── 00044.mpls
│   │   │   ├── 00045.mpls
│   │   │   ├── 00050.mpls
│   │   │   ├── 00051.mpls
│   │   │   ├── 00052.mpls
│   │   │   ├── 00053.mpls
│   │   │   ├── 00054.mpls
│   │   │   ├── 00055.mpls
│   │   │   ├── 00091.mpls
│   │   │   ├── 00093.mpls
│   │   │   ├── 00094.mpls
│   │   │   ├── 00100.mpls
│   │   │   ├── 00101.mpls
│   │   │   ├── 00120.mpls
│   │   │   ├── 00201.mpls
│   │   │   └── 00401.mpls
│   │   └── index.bdmv
│   ├── CLIPINF
│   │   ├── 00000.clpi
│   │   ├── 00002.clpi
│   │   ├── 00003.clpi
│   │   ├── 00004.clpi
│   │   ├── 00005.clpi
│   │   ├── 00006.clpi
│   │   ├── 00007.clpi
│   │   ├── 00008.clpi
│   │   ├── 00009.clpi
│   │   ├── 00010.clpi
│   │   ├── 00011.clpi
│   │   ├── 00012.clpi
│   │   ├── 00013.clpi
│   │   ├── 00014.clpi
│   │   ├── 00015.clpi
│   │   ├── 00016.clpi
│   │   ├── 00017.clpi
│   │   ├── 00018.clpi
│   │   ├── 00019.clpi
│   │   ├── 00020.clpi
│   │   ├── 00021.clpi
│   │   ├── 00022.clpi
│   │   ├── 00024.clpi
│   │   ├── 00025.clpi
│   │   ├── 00026.clpi
│   │   ├── 00027.clpi
│   │   ├── 00028.clpi
│   │   ├── 00029.clpi
│   │   ├── 00030.clpi
│   │   ├── 00031.clpi
│   │   ├── 00032.clpi
│   │   ├── 00033.clpi
│   │   ├── 00034.clpi
│   │   ├── 00035.clpi
│   │   ├── 00036.clpi
│   │   ├── 00037.clpi
│   │   ├── 00038.clpi
│   │   ├── 00039.clpi
│   │   ├── 00041.clpi
│   │   ├── 00042.clpi
│   │   ├── 00043.clpi
│   │   ├── 00044.clpi
│   │   ├── 00045.clpi
│   │   ├── 00046.clpi
│   │   ├── 00047.clpi
│   │   ├── 00048.clpi
│   │   ├── 00049.clpi
│   │   ├── 00050.clpi
│   │   ├── 00051.clpi
│   │   ├── 00052.clpi
│   │   ├── 00053.clpi
│   │   ├── 00058.clpi
│   │   ├── 00059.clpi
│   │   ├── 00060.clpi
│   │   ├── 00061.clpi
│   │   ├── 00062.clpi
│   │   ├── 00063.clpi
│   │   └── 00069.clpi
│   ├── META
│   │   └── DL
│   │       ├── Striptease_metadata416.jpg
│   │       ├── Striptease_metadata640.jpg
│   │       ├── bdmt_deu.xml
│   │       ├── bdmt_eng.xml
│   │       ├── bdmt_jpn.xml
│   │       └── bdmt_spa.xml
│   ├── MovieObject.bdmv
│   ├── PLAYLIST
│   │   ├── 00011.mpls
│   │   ├── 00012.mpls
│   │   ├── 00013.mpls
│   │   ├── 00014.mpls
│   │   ├── 00015.mpls
│   │   ├── 00016.mpls
│   │   ├── 00017.mpls
│   │   ├── 00018.mpls
│   │   ├── 00022.mpls
│   │   ├── 00023.mpls
│   │   ├── 00024.mpls
│   │   ├── 00025.mpls
│   │   ├── 00026.mpls
│   │   ├── 00027.mpls
│   │   ├── 00028.mpls
│   │   ├── 00031.mpls
│   │   ├── 00032.mpls
│   │   ├── 00033.mpls
│   │   ├── 00034.mpls
│   │   ├── 00035.mpls
│   │   ├── 00036.mpls
│   │   ├── 00038.mpls
│   │   ├── 00039.mpls
│   │   ├── 00040.mpls
│   │   ├── 00041.mpls
│   │   ├── 00042.mpls
│   │   ├── 00043.mpls
│   │   ├── 00044.mpls
│   │   ├── 00045.mpls
│   │   ├── 00050.mpls
│   │   ├── 00051.mpls
│   │   ├── 00052.mpls
│   │   ├── 00053.mpls
│   │   ├── 00054.mpls
│   │   ├── 00055.mpls
│   │   ├── 00091.mpls
│   │   ├── 00093.mpls
│   │   ├── 00094.mpls
│   │   ├── 00100.mpls
│   │   ├── 00101.mpls
│   │   ├── 00120.mpls
│   │   ├── 00201.mpls
│   │   └── 00401.mpls
│   ├── STREAM
│   │   ├── 00000.m2ts
│   │   ├── 00002.m2ts
│   │   ├── 00003.m2ts
│   │   ├── 00004.m2ts
│   │   ├── 00005.m2ts
│   │   ├── 00006.m2ts
│   │   ├── 00007.m2ts
│   │   ├── 00008.m2ts
│   │   ├── 00009.m2ts
│   │   ├── 00010.m2ts
│   │   ├── 00011.m2ts
│   │   ├── 00012.m2ts
│   │   ├── 00013.m2ts
│   │   ├── 00014.m2ts
│   │   ├── 00015.m2ts
│   │   ├── 00016.m2ts
│   │   ├── 00017.m2ts
│   │   ├── 00018.m2ts
│   │   ├── 00019.m2ts
│   │   ├── 00020.m2ts
│   │   ├── 00021.m2ts
│   │   ├── 00022.m2ts
│   │   ├── 00024.m2ts
│   │   ├── 00025.m2ts
│   │   ├── 00026.m2ts
│   │   ├── 00027.m2ts
│   │   ├── 00028.m2ts
│   │   ├── 00029.m2ts
│   │   ├── 00030.m2ts
│   │   ├── 00031.m2ts
│   │   ├── 00032.m2ts
│   │   ├── 00033.m2ts
│   │   ├── 00034.m2ts
│   │   ├── 00035.m2ts
│   │   ├── 00036.m2ts
│   │   ├── 00037.m2ts
│   │   ├── 00038.m2ts
│   │   ├── 00039.m2ts
│   │   ├── 00041.m2ts
│   │   ├── 00042.m2ts
│   │   ├── 00043.m2ts
│   │   ├── 00044.m2ts
│   │   ├── 00045.m2ts
│   │   ├── 00046.m2ts
│   │   ├── 00047.m2ts
│   │   ├── 00048.m2ts
│   │   ├── 00049.m2ts
│   │   ├── 00050.m2ts
│   │   ├── 00051.m2ts
│   │   ├── 00052.m2ts
│   │   ├── 00053.m2ts
│   │   ├── 00058.m2ts
│   │   ├── 00059.m2ts
│   │   ├── 00060.m2ts
│   │   ├── 00061.m2ts
│   │   ├── 00062.m2ts
│   │   ├── 00063.m2ts
│   │   └── 00069.m2ts
│   └── index.bdmv
├── CERTIFICATE
│   ├── BACKUP
│   │   ├── app.discroot.crt
│   │   ├── bu.discroot.crt
│   │   └── id.bdmv
│   ├── app.discroot.crt
│   ├── bu.discroot.crt
│   └── id.bdmv
├── Striptease.1996.MULTi.COMPLETE.BLURAY-GerHD.nfo
├── backdrop.jpg
├── folder.jpg
└── logo.png

11 directories, 280 files
holow29 commented 2 years ago

Working fine for me. Can you try other blurays? Are you using native mode or addon mode? Can you paste the error from the logs?

yswtrue commented 2 years ago

Some other bluerays seams works well, I use addon mode. How can I get error logs