search

jellyfin / jellyfin-kodi

Jellyfin Plugin for Kodi
https://jellyfin.org
GNU General Public License v3.0
850 stars 113 forks source link

If jellyfin doesn't fetch all metadata, kodi never updates the album name #763

Open csaavedra opened 1 year ago

csaavedra commented 1 year ago

Sometimes when I add a new album to Jellyfin, for some reason Jellyfin doesn't fetch all the metadata (see https://github.com/jellyfin/jellyfin/issues/6340). For example instead of the album name it uses the directory with the files instead. This information is fetched by the plugin for kodi (hence using the dir name instead of the album name). If I manually update the metadata in Jellyfin to get the missing stuff (via fetch missing metadata or update library), the missing metadata gets added to Jellyfin (the actual album name), but that never gets reflected in Kodi, which continues to use the incomplete metadata.

The only way so far I have found to fix this is to "repair library", but that basically means to scan everything from scratch again.

csaavedra commented 1 year ago

I figured out that this seems to be specific to the album name only. Kodi does get updated info (genres, cover art, track names) but the album name never gets updated and the directory is always used.

csaavedra commented 8 months ago

I was reading the code of the plugin, and I notice that, indeed, during album updates, the plugin does not update the album name. So if for some reason the album name gets updated in Jellyfin, kodi stays with the old name. This is done here https://github.com/jellyfin/jellyfin-kodi/blob/master/jellyfin_kodi/objects/music.py#L147-L155 and then here https://github.com/jellyfin/jellyfin-kodi/blob/master/jellyfin_kodi/objects/kodi/queries_music.py#L182-L199 so it's clear that this is not done.