oddstr13
commented
5 months ago Unable to reproduce, seems to be working for me
Open Bujiraso opened 5 months ago
oddstr13
commented
5 months ago Unable to reproduce, seems to be working for me
Bujiraso
commented
5 months ago Anything further you need to debug the issue or steps i can take to fix it? It works with -- say -- ripped MKV's by the way, it has to be the backed up files of the BRD itself, are you using that? For myself I take MakeMKV and just click the Backup button.
Bujiraso
commented
5 months ago Just reproduced again from a different host on the LAN. Another quick check -- I am also trying to use the subtitles embedded into the BRD files, not an additional subtitle provider, which may or may not work but is not what is failing.
Version Info:
$ kod --version
Kodi Media Center 21.0 (21.0.0) Git:21.0-Omega
Copyright (C) 2005-2021 Team Kodi - http://kodi.tv<addon id="plugin.video.jellyfin" name="Jellyfin" version="1.0.3+py3" provider-name="Jellyfin Contributors, angelblue05">OS: NixOS, 24.05
here's a little show of good faith that the disc itself does have a subtitle that the Jellyfin web viewer is happy to use. I've tested this multiple times and it's good.
oddstr13
commented
3 months ago Yes, my test was made with a BDMV directory structure. Are you seeing this with all items, or just some?
Bujiraso
commented
3 months ago Yep, any of the discs I try have this problem and (as it turns out) the audio track selection is having the identical issue but I didn't notice that before I titled the bug. I did do a little debugging (but I don't think I can personally fix it or anything).
Regarding the audio track selections, it seems like an identical bug. A default selection is picked, it's often the wrong one (e.g. director's commentary), and then when I use the Kodi menus to try and select another track, they aren't there.
Regarding the subtitles, the way my discs and Jellyfin are set up, it wants to stream the subtitles and not let them be downloaded. When you hit play, there's no valid selected subtitle stream index.
The TranscodingUrl doesn't include any SubtitleStreamIndex, but I notice that if I hard-code one in for a particular piece of media where I know the right values, Kodi seems to know what to do with that and it lets the user toggle the subtitles on and off successfully. The media streams include subtitles that look like this:
{
"Codec": "PGS",
"Language": "eng",
"VideoRange": "Unknown",
"VideoRangeType": "Unknown",
"AudioSpatialFormat": "None",
"LocalizedUndefined": "Undefined",
"LocalizedDefault": "Default",
"LocalizedForced": "Forced",
"LocalizedExternal": "External",
"LocalizedHearingImpaired": "Hearing Impaired",
"DisplayTitle": "English - PGS",
"IsInterlaced": false,
"IsDefault": false,
"IsForced": false,
"IsHearingImpaired": false,
"Type": "Subtitle",
"Index": 2,
"IsExternal": false,
"IsTextSubtitleStream": false,
"SupportsExternalStream": false
}Is there anything amiss here?
mcarlton00
commented
3 months ago If you're transcoding for whatever reason, then subtitles have to be chosen before the stream starts. They can't be adjusted after playback has started, because iirc that requires stopping and restarting the transcode stream. And currently, all BDMV files will trigger a transcode in Kodi. Not sure why yet. However, this behavior applies to all transcoded streams, not just BDMV sources.
There's also quite a few quirks about using BDMV folder structure that aren't real well documented because nobody on the team really uses them. I have exactly 1 just because of trying to reproduce another bug that's specific to BDMVs (the above mentioned transcoding issue).
Describe the bug When playing from an unencrypted BluRay copy, subtitles are not available. If using Jellyfin in the browser, there's no problem, it's in the Subtitles and can be toggled, but from Kodi (on OSMC) if you enable the subtitles nothing happens and if you search the subtitles there is only
None.To Reproduce
Expected behavior Subtitles can be enabled
Logs
Long log output from today, tried to play it twice
```txt 2024-06-05 09:50:30.278 T:3908 infoScreenshots n/a
System (please complete the following information):
Additional context Tried it with multiple TV shows and multiple other clients; all good except this plug-in. Please feel free to give tips as to where to troubleshoot in the code, I may be able to pitch in with some guidance as to where to start.
Thanks for this great plugin! :pray: