jellyfin / jellyfin-media-player

Jellyfin Desktop Client
GNU General Public License v2.0
3.25k stars 323 forks source link

I'd like to request Esc work to leave fullscreen #186

Open dscottboggs opened 2 years ago

dscottboggs commented 2 years ago

Describe the solution you'd like If the media player is in fullscreen, pressing the ESC key would leave fullscreen.

Describe alternatives you've considered Learning to press F instead.

whiteowl3 commented 2 years ago

i think youd want to start here: https://github.com/jellyfin/jellyfin-media-player/blob/master/src/ui/webview.qml

iwalton3 commented 2 years ago

So the funny thing about this application is that there are two fullscreen modes. If you click the fullscreen button in the web app, it is “temporary fullscreen” which I believe also is dismissed when you quit from a video. I am pretty sure this responds to ESC.

Then there is “permanent fullscreen” which is what the settings dialog and I believe F11 set. This is persisted between actions and launching the application and is what you would typically use on a dedicated HTPC.

dscottboggs commented 2 years ago

I see what you mean now. Just to outline the behavior, here's what I'm observing:

Under none of these conditions does ESC do anything for me.


Edit: Strange, I see all the other features (play-pause, nav, etc) in this mapping file but I don't see a mapping for F. So, why does the player respond to it?

mjpieters commented 1 year ago

Strange, I see all the other features (play-pause, nav, etc) in this mapping file but I don't see a mapping for F. So, why does the player respond to it?

Because the desktop client loads the Jellyfin Web client, and it is the web client that responds to F. See the web player controllers/playback/video/index.js source file. The web client is managed by the webview.qml file linked earlier.

I am looking for why the ESC and backspace keys don't work for me, I suspect they are not being proxied properly, at least in my Macbook Pro (M1 Pro) context.

However, now that I found webview.qml I can see that StandardKey.Back will work, and the Qt keyboard shortcuts docs tell me that that's mapped to ⌘-[ (Command-open_bracket), so I at least have a work-around now.

felix920506 commented 7 months ago

I am using the current 1.9.1 release on Linux Mint 21.3 with Cinnamon desktop and JMP installed with flatpak doesn't respond to the esc key when in fullscreen.