search

jellyfin / jellyfin-media-player

Jellyfin Desktop Client
GNU General Public License v2.0
2.87k stars 296 forks source link

Update the WebEngine to Qt6 to support more CSS styling #282

Open Nicryc opened 1 year ago

Nicryc commented 1 year ago

Is your feature request related to a problem? Please describe. Currently this project use Qt 5.15.2 (according to the README file) which corresponds for the WebEngine to Chromium v83 which is quite old now (19/05/2020). Some CSS properties are not supported like :not with a selector list argument and therefore can affect CSS custom themes.

Describe the solution you'd like Update to the latest version of Qt which is Qt6.

Describe alternatives you've considered None.

Additional context I really don't know how much work this is or how much it could affect platforms support, but it would be cool for CSS theme makers out there.

iwalton3 commented 1 year ago

I know whiteowl was taking a look. It would be fine for some platforms, but others (like Debian) aren't shipping QT 6 yet in their stable repositories. Flatpak does have a QT 6 runtime.

abhiaagarwal commented 1 year ago

Fyi, qt6 has been accepted into unstable, so stable may be coming soon.

https://tracker.debian.org/pkg/qt6-base

sevenrats commented 1 year ago

this branch builds on qt6, but has some issues in mpvVideoPlayer.js. z indexes are screwed up. the video directplays properly, but the video is not properly displayed. its somewhere in the stack though, and you can hear it playing. if somebody can fix that its usable. https://github.com/sevenrats/jellyfin-media-player/tree/qt6