jellyfin / jellyfin-media-player

Jellyfin Desktop Client
GNU General Public License v2.0
2.9k stars 298 forks source link

[Issue]: Multiple screen bug #310

Closed sakej closed 1 year ago

sakej commented 1 year ago

Please describe your bug

How to reproduce:

Use JMP with at least 2 screens (monitors) connected to laptop Play a movie in full screen (full screen not maximised) mode on non primary monitor Press back arrow in left upper corner / go out of full screen mode / let movie runs out

Remarks: This is only a case if you go to full screen form maximized window

Issue: JMP jumps to main monitor

Proper behaviour: JMP stays on the same screen

This is very frustrating especially at night when I'm watching form bed and second monitor is turned off, if I forgot to leave it on maximized window and JMP jumps to screen that is turned off ;/

Jellyfin Version

Other

if other:

10.8.4

Environment

- OS:Win 10 for a client / Ubuntu server 20.04.5 for a server
- Virtualization: No
- Clients:JMP
- Browser: -- 
- FFmpeg Version: newest
- Playback Method: JMP
- Hardware Acceleration: NVIDIA
- Plugins: AniDB, AudioDB, Fanart, Merge Versions, MusicBrainz, NapiSub, OMDb, OPDS Feed, Open subtitles, Playback reporting, Session cleaner, SkinManager, Studio Images, TMDb, TMDb Box Sets
- Reverse Proxy: 
- Base URL:
- Networking:
- Storage:

Jellyfin logs

No response

FFmpeg logs

No response

Please attach any browser or client logs here

No response

Please attach any screenshots here

No response

Code of Conduct

sakej commented 1 year ago

correction - it jumps to other screen doesn't matter if its set as a main one or not

Xavier-Do commented 1 year ago

I confirm this issue.

It looks like it registers the last screen where it went from windowed to full-screen without being maximised. In other words, when going from maximized to fullscreen the current screen is not registered if it makes sence.

Edit: https://github.com/jellyfin/jellyfin-media-player/commit/85715bb32284eda00afcd79b824dbb20895d8a23 may be a good start to find a solution cc @tru

tru commented 1 year ago

This is code I wrote in 2016 - when working for Plex working on our player there. I am no longer working for Plex and the Plex Media Player has been discontinued a long time ago. You are all welcome to use the open source code, but don't expect any of the old Plex devs work on it.

Xavier-Do commented 1 year ago

This is code I wrote in 2016 - when working for Plex working on our player there. I am no longer working for Plex and the Plex Media Player has been discontinued a long time ago. You are all welcome to use the open source code, but don't expect any of the old Plex devs work on it.

This was an expectable answer, thanks anyway :)

iwalton3 commented 1 year ago

Duplicate of #245