search

jellyfin / jellyfin-media-player

Jellyfin Desktop Client
GNU General Public License v2.0
3.17k stars 315 forks source link

Doesn't run on Macos High Sierra #380

Closed satmandu closed 9 months ago

satmandu commented 1 year ago

As I understand it GitHub only supports the last two versions of operating systems for building binaries.

Could we have some external builders setup to build for older Macos versions?

(There are people I know with older machines that for instance cannot update past Macos High Sierra, which came out in 2017.)

iwalton3 commented 1 year ago

I'm sorry but I don't have the resources to accomplish this. If someone else wants to maintain community builds for older operating systems that GutHub Actions does not support, feel free to.

satmandu commented 1 year ago

Would you be willing to accept builds for older versions of Macos?

xeeeeeeeee commented 1 year ago

I've been trying to compile with macOS 11.6.1 but I always have problems with the DQTROOT. It's always complaining it can't find Qt5Core or other cmake files. Any tips?

iwalton3 commented 1 year ago

Read the CI flow here for specific commands: https://github.com/jellyfin/jellyfin-media-player/blob/884a2804e19a1102974240a39931366f2c73b5e0/.github/workflows/main.yml#L11

For installing QT, you can use this installer to avoid needing to create an account: https://github.com/miurahr/aqtinstall#install

xeeeeeeeee commented 1 year ago

Thanks! With aqt was quite easy to build it. If you want the dmg, I can share it.

This was what I used,

Then at the jellyfin folder, cmake -GNinja -DQTROOT=/Users/fcmonteiro/Documents/Qt/5.15.2/clang_64/ -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=output ..

satmandu commented 1 year ago

@xeeeeeeeee Would you be willing to share the build dmg you made for older macos versions?

xeeeeeeeee commented 1 year ago

Sure, check this link. https://mega.nz/file/oCAA2LjY#pkknS3boqtDYpckjnzSLSBSaN2moWzSGpb7v_EQGiWo

satmandu commented 1 year ago

Thanks!

Alas, I need a version for High Sierra (10.13)...

I guess I'll have to spin up a 10.13 VM to make that happen.

satmandu commented 1 year ago

Fun fact, building JMP on macos 10.13 high sierra with homebrew is currently impossible, owing to an inability to compile mpv on homebrew on 10.13, due to broken subprojects which mpv needs, such as jpeg-xl, which no longer build on 10.13.

sevenrats commented 9 months ago

High Sierra has been EOL for more than 3 years, as such we will not be implementing support for it. Feel free to fork for this purpose.