jellyfin / jellyfin-media-player

Jellyfin Desktop Client
GNU General Public License v2.0
2.87k stars 297 forks source link

Window is rendered at framerate of video playing #698

Open dolceAlka opened 3 weeks ago

dolceAlka commented 3 weeks ago

Issue observed across both flatpak linux version and windows version, 11.1 on both and applies to many older versions as well. The entire JMP window is rendered at the framerate of the video while playing, which leads to UI elements such as subtitle selection being very sluggish if the framerate of the video is low like 24fps. The issue does not occur on the web client and may be a quirk with qtwebengine which is what I think is being used for JMP, (not observed in chromium browsers or firefox)

Expected: UI elements render at display framerate while video plays at its own To Replicate: play a video of a low-ish fps 24 or below and click on subtitle menu or audio menu while playing

TimGels commented 3 weeks ago

Can confirm that when a video is playing, my content is 21fps, it becomes unreasonably slow. Not sure if it actually renders at the video fps, but it really is slow so I wouldn't be surprised.

MulverineX commented 2 weeks ago

AFAICT this also causes CEF to freeze / hangs the whole app when you start playback (until the request resolves & the decoded stream is received from MPV). This also causes issues on Windows because of the "Not Responding" label that appears. It would be far more user friendly if this was performed on another thread.

ysenner commented 1 week ago

I have the same issue. For some reason it seams to fix itself when I press the Cast button during playback and select My Device, i.e. I start casting to the same device. No idea why.

dolceAlka commented 1 week ago

i'm unable to replicate that on my side, can you try it on another system or device?

ysenner commented 1 week ago

i'm unable to replicate that on my side, can you try it on another system or device?

Nevermind, can't replicate it myself now, it is always running at low fps now. I have no idea what changed.