jellyfin / jellyfin-media-player

Jellyfin Desktop Client
GNU General Public License v2.0
2.87k stars 297 forks source link

Right-click reload not working on Windows and MacOS since v1.11.0 #705

Open FizzyRust opened 2 weeks ago

FizzyRust commented 2 weeks ago

Describe the bug Since the update of JMP from v1.10.1 to v.11.1, reloading the jellyfin client through right clicking and choosing reload leads to playback issues on both MacOS and Windows.

To Reproduce on Windows 10 Steps to reproduce the behavior:

  1. Use version v1.11.1 on windows
  2. Start JMP and right click on any empty space
  3. Select reload
  4. Start playback
  5. Get stuck on a screen with video thumbnail, cant exit without restarting

Expected behavior on Windows 10 Video playback should work the same way it did before reloading.

To Reproduce on MacOS Steps to reproduce the behavior:

  1. Use version v1.11.1 on MacOS
  2. Start JMP and right click on any empty space
  3. Select reload
  4. Start playback
  5. Playback starts, but intro skipper icon is different, and subtitles don't display.

Expected behavior on MacOS After reloading, intro skipper icon remains the same, and subtitles display.

Screenshots

Intro skipper button on MacOS before reloading:

macos_before_reload

Intro skipper button on MacOS after reloading:

MacOS_after_reload

Intro skipper button on Firefox, default jellyfin-web:

webplayer_on_firefox

Desktop

Web-debug logs: Windows 10 web-debug logs, before reloading: https://pastebin.com/dxYcudQy

Windows 10 web-debug logs, after reloading: https://pastebin.com/4aeanG96

Additional context It seems that reloading causes JMP to start displaying the web player instead of the built in one, I don't know why playback completely stops on windows as opposed to MacOS where it keeps going, but without subtitles. I believe that the subtitles not displaying on MacOS is connected to subtitles not being burned in when they should be.