jellyfin / jellyfin-media-player

Jellyfin Desktop Client
GNU General Public License v2.0
2.87k stars 297 forks source link

Offer controls for track (subtitle) synchronization #717

Closed rexendevar closed 3 days ago

rexendevar commented 6 days ago

Is your feature request related to a problem? Please describe. I can't stand when the subtitles are seconds off the audio. Unofrtunately this is a constant occurrence. Would like to be able to make them happen earlier or later to compensate.

Describe the solution you'd like Under the subtitles submenu in the player, I would like a little section at the top with a number field for seconds of offset and two radio buttons for "earlier" or "later." Offset would start at 0.00 seconds and the other two buttons would be grayed out until a value is entered (maybe could also use arrow keys or scroll wheel on the number field). You could implement the same feature under the audio selector submenu as well to offset the audio track from the video but this isn't something I've ever personally required. Also the UI I describe is just a concept to make it easier than VLC's system

Describe alternatives you've considered VLC has this but it's a massive pain to set up. The number field is garbage, it takes ages to register the change and the program keeps crashing. Jellyfin is how I watch all my movies anyway & I don't enjoy switching programs.

Additional context image this is what it looks like in VLC so u know what I'm talking about

wouterx commented 4 days ago

maybe i dont understand, jellyfin media player already has the ability to adjust subtitle timing.

rexendevar commented 4 days ago

have i been switching programs for nothing??? how do i do that

On Fri, Jun 28, 2024, 4:51 PM wouterx @.***> wrote:

maybe i dont understand, jellyfin media player already has the ability to adjust subtitle timing.

— Reply to this email directly, view it on GitHub https://github.com/jellyfin/jellyfin-media-player/issues/717#issuecomment-2197217307, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALGGC2IMRONUK6QZTFPPAA3ZJWA7DAVCNFSM6AAAAABJ66UU3OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJXGIYTOMZQG4 . You are receiving this because you authored the thread.Message ID: @.***>

wouterx commented 3 days ago

while playing, turn subtitles on, press settings, press subtitle timing (could be named differently, i am using another language), then you can adjust timing on the fly.

rexendevar commented 3 days ago

I have pressed every little button at the bottom of my screen and found nothing of the sort. what settings? i pressed the cog icon and it only gives me resolution options

On Sat, Jun 29, 2024, 10:15 AM wouterx @.***> wrote:

while playing, turn subtitles on, press settings, press subtitle timing (could be named differently, i am using another language), then you can adjust timing on the fly.

— Reply to this email directly, view it on GitHub https://github.com/jellyfin/jellyfin-media-player/issues/717#issuecomment-2198058545, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALGGC2LN7VRIY22WHVARA3DZJZ3KZAVCNFSM6AAAAABJ66UU3OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJYGA2TQNJUGU . You are receiving this because you authored the thread.Message ID: @.***>

wouterx commented 3 days ago

then maybe you are not using the "jellyfin media player" for desktop, but another jellyfin client, like the google tv one..........?

rexendevar commented 3 days ago

I'm on the android one currently. i assumed there was more or less feature parity between all fully updated platforms

On Sat, Jun 29, 2024, 12:47 PM wouterx @.***> wrote:

then maybe you are not using the "jellyfin media player" for windows, but another jellyfin client, like the google tv one..........?

— Reply to this email directly, view it on GitHub https://github.com/jellyfin/jellyfin-media-player/issues/717#issuecomment-2198123151, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALGGC2ICRMNSH7UTY46RTZTZJ2NGNAVCNFSM6AAAAABJ66UU3OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJYGEZDGMJVGE . You are receiving this because you commented.Message ID: @.***>

wouterx commented 3 days ago

this is specifically for the desktop clients "Jellyfin media player", so your request should go elsewhere