jellyfin / jellyfin-media-player

Jellyfin Desktop Client
GNU General Public License v2.0
3.21k stars 319 forks source link

HDR is bugged, SDR slider and or Tonemapping issues #753

Open kraM1tt opened 2 months ago

kraM1tt commented 2 months ago

Describe the bug With HDR enabled in Windows, JMP does not correctly display HDR content. It appears to be tonemapping. The SDR slider influences the video brightness, but it should not, as it's only for SDR content. This happens whether in Fullscreen or Windowed, restarting the app after toggling HDR off/on etc etc. Youtube has the correct behaviour if you want to compare.

To Reproduce Steps to reproduce the behavior: Open any HDR video, windowed or fullscreen, and adjust the SDR slider.

Expected behavior Youtube works perfectly, the video is shown at 100% brightness with full metadata passthrough, the rest of Windows obeys the SDR slider brightness (as Windows isn't rendered in HDR)

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

https://github.com/user-attachments/assets/7d7cbcc8-c2fb-4729-ace5-9c7d3c2ab194

:Edit: I also tested with MPC-HC with MadVR and it works correctly just like youtube. But I don't want to use this player as it doesn't link with Jellyfin!

2at9atDorsia commented 2 months ago

Also having same issue with Jellyfin. Using Windows 11 and lastest version of JF as of today, through Windows. If I play HDR content through native LG TV app on Jellyfin, the HDR picture seems genuine. If I switch back to desktop and play the same moment of a HDR film on Jellyfin app on Windows PC with HDR enabled, the quality is worse than that of SDR mode. And like yourself, Youtube is fine, so the issue here lies between Windows and Jellyfin. Hope you get this sorted, new friend of mine. Take care sir!

DutchComputerKid commented 1 day ago

Same issue here. Turn off tone mapping or not using NVENC/NVDEC makes things worse but on any player, web, desktop or Android, it always looks grey and washed out.

No clue when this started, but SDR always look better now. Enforcing HDR transcoding on the desktop player does not do anything to fix this, whatever it is. But agreed, somewhere in the transcoding pipeline HDR tonemapping is broken.

Image Image