jellyfin / jellyfin-media-player

Jellyfin Desktop Client
GNU General Public License v2.0
3.11k stars 312 forks source link

JMP 1.11.1 removes trailing slash which makes it unable to connect to my Jellyfin server #754

Open fredguile opened 1 month ago

fredguile commented 1 month ago

Describe the bug On my shared Jellyfin server, everything is secured via basic auth with exception of that URL "/username/jellyfin/" - pay attention to that trailing slash - and sadly I don't have any way to change that (hint: it's a well-known service used by many).

As since this commit, JMP 1.11.1 will strip out the trailing slash, it makes it unable to connect, as basic auth isn't supported AFAIK.

I would like to open a tiny fix PR touching "find-webclient.js" in order to unblock this.

To Reproduce You need to assume that your Jellyfin server is secured with basic auth on pretty much every URL except "/jellyfin/*" (that trailing slash is of a utmost importance).

Steps to reproduce the behavior:

  1. Just log-in as usual, the login process wouldn't succeed as failing on a 401 auth required as seen in the dev tools

Expected behavior We could just not slash that trailing slash, this would solve the issue.

Desktop (please complete the following information):

Additional context That bug seems low priority, but it probably affects many JMP users utilizing a well-known app sharing provider.