jellyfin / jellyfin-media-player

Jellyfin Desktop Client
GNU General Public License v2.0
3.28k stars 323 forks source link

Don't junk the server URL if subsequent connection failed #789

Open p0358 opened 3 weeks ago

p0358 commented 3 weeks ago

So currently a failure to connect to a previously saved server will present an empty server connect page again.

But this sucks, because either the server or user's internet connection might be down, and we know the server should be okay since it worked before. So this fills out the address text input with the currently saved server, this way the user can easily retry the connection without being frustrated that the server URL was junked and they gotta pull it out of memory and re-type to reconnect.

Now the way I understand it, it was never junked from the local storage to begin with, so technically they'd be able to reconnect by restarting the app too? But nobody would ever guess that if they see empty connection form, they'd assume all was reset.

Also it is my sincere hope that in such a situation local storage in terms of login data won't be junked either hopefully, but even if it does, this PR is still going to make it all a bit less of PITA for users