jellyfin / jellyfin-meta

A repository to hold our roadmap, policies, and more.
25 stars 4 forks source link

Cast receiver configuration #45

Closed nielsvanvelzen closed 1 year ago

nielsvanvelzen commented 1 year ago

To ease cast client development and make it easier to use third-party/self hosted implementations I propose some changes to how we deal with the cast receiver id in the server/web. The main changes of this proposal are:

I'm searching for someone to tackle the server part of this proposal. I can do the web part myself (although if someone from the web team wants to do that, please do!).

Jellyfin server changes

Jellyfin web changes


This effectively supersedes #7 (which I noticed existed after I made this draft).

crobibero commented 1 year ago

I'll work on the server part 👍

nielsvanvelzen commented 1 year ago

I can work on the web part in about a week or so, unless someone else volunteers to do the web part. It should be fairly easy with basic knowledge about the jellyfin-web codebase.

BloodyIron commented 1 year ago

🍿

I've seen mentioned this kind of a change might make it into Jellyfin (server?) 10.9. Is that a reliable/achievable milestone? I don't entirely know how frequently minor version changes roll out for Jellyfin server/etc. So unsure what realistic napkin-math timeline to temper my anticipation with. Excited! :)

nielsvanvelzen commented 1 year ago

With half of the implementation already done this is extremely likely to be in 10.9 yes.

nielsvanvelzen commented 1 year ago

Closing as resolved. Both the server and client changes are merged for 10.9!

BloodyIron commented 1 year ago

Will these settings be configurable via the webGUI for the Admin section of Jellyfin? In... addition to CLI? Also, how exactly can one know acceptable values for said fields? Since the "id" value seems to accept what I assume is git hashes, not sure exactly the best way a human can determine possible workable values in said fields (CLI/webGUI whatever).

nielsvanvelzen commented 1 year ago

No you cannot change the list of cast receivers via the webui/cli. You'll need to modify the configuration file. This is done because this configuration is only for advanced use cases like development or when self-hosting the receiver, both require a Google Cast developer account (which is not free) and the expectation is that not a lot of users will do this.

The ids are not git hashes, those are the cast receiver ids Google generates.

BloodyIron commented 1 year ago

both require a Google Cast developer account (which is not free)

Well I didn't even know this part lol! That's absolute bonkers self-hosting that data (as opposed to pulling from github?) requires a Google Cast developer account. Does the github (current?) method involve a Google Cast developer account somehow? 🤔

Maxr1998 commented 1 year ago

The current method uses cast clients hosted by the Jellyfin team.