Open iyzana opened 2 years ago
Have you tried disabling the update check in the config file?
I just disabled it and can confirm that its the update check that causes the bug. I also noticed that the keyboard shortcuts start working again after the request to github.com times out after two minutes.
times out after two minutes
So this is supposed to time out after 3 seconds, but I realized it was making three requests. The new push to master should only make one.
This should be fixed once I post a new release. Please re-open after upgrading and re-testing if it is still present.
I assume version 2.1.0 is the new release you mentioned. If so this problem still persists, although the timeout seems to be 15 seconds now. My issue is not about the duration of the timeout though, but that the keyboard shortcuts do not work in that time.
I can't reopen the ticket myself.
Just tested version 2.2.0 as well, the bug is still there and the timeout seems to be 2 minutes again.
Description
I have a jellyfin instance and jellyfin-mpv-shim running on the same computer. Most times this computer has an internet connection, but sometimes my modem crashes and I don't have an outgoing internet connection. Whenever that happens jellyfin and jellyfin-mpv-shim keep working, but - a bit strangely - most of
mpv
s keyboard shortcuts stop working. Not all.p
,i
ando
still work, butf
,<space>
orq
don't.My wild uninformed guess would be, that the update check to github blocks a thread that is used for input processing.
To Reproduce
Expected behavior The video pauses
Desktop (please complete the following information):
Error Messages
Logs
``` 2022-04-26 18:30:34,552 [ INFO] conf: Loaded settings from json: /home/me/.config/jellyfin-mpv-shim/conf.json 2022-04-26 18:30:34,610 [ INFO] player: Using libmpv1 playback backend. 2022-04-26 18:30:34,628 [ DEBUG] JELLYFIN.jellyfin_apiclient_python.client: JellyfinClient initializing... 2022-04-26 18:30:34,628 [ DEBUG] JELLYFIN.jellyfin_apiclient_python.configuration: Configuration initializing... 2022-04-26 18:30:34,628 [ DEBUG] JELLYFIN.jellyfin_apiclient_python.configuration: Begin http constructor. 2022-04-26 18:30:34,628 [ DEBUG] JELLYFIN.jellyfin_apiclient_python.ws_client: WSClient initializing... 2022-04-26 18:30:34,628 [ DEBUG] JELLYFIN.jellyfin_apiclient_python.connection_manager: ConnectionManager initializing... 2022-04-26 18:30:34,628 [ DEBUG] JELLYFIN.jellyfin_apiclient_python.credentials: Credentials initializing... 2022-04-26 18:30:34,628 [ DEBUG] JELLYFIN.jellyfin_apiclient_python.configuration: Begin app constructor. 2022-04-26 18:30:34,628 [ INFO] JELLYFIN.jellyfin_apiclient_python.connection_manager: Begin connect 2022-04-26 18:30:34,628 [ INFO] JELLYFIN.jellyfin_apiclient_python.connection_manager: Begin getAvailableServers 2022-04-26 18:30:34,628 [ DEBUG] JELLYFIN.jellyfin_apiclient_python.credentials: credentialsupdated 2022-04-26 18:30:34,629 [ INFO] JELLYFIN.jellyfin_apiclient_python.connection_manager: connect has 1 servers 2022-04-26 18:30:34,629 [ INFO] JELLYFIN.jellyfin_apiclient_python.connection_manager: begin connectToServer 2022-04-26 18:30:34,629 [ INFO] JELLYFIN.jellyfin_apiclient_python.api: Sending get request to system/info/public 2022-04-26 18:30:34,629 [ DEBUG] JELLYFIN.jellyfin_apiclient_python.api: 5 2022-04-26 18:30:34,629 [ DEBUG] JELLYFIN.jellyfin_apiclient_python.api: {'Accept': 'application/json', 'Content-type': 'application/x-www-form-urlencoded; charset=UTF-8', 'X-Application': 'Jellyfin MPV Shim/2.0.1', 'Accept-Charset': 'UTF-8,*', 'Accept-encoding': 'gzip', 'User-Agent': 'Jellyfin-MPV-Shim/2.0.1', 'x-emby-authorization': 'MediaBrowser Client=Jellyfin MPV Shim, Device=pc, DeviceId=bef57e4f-8252-4309-97da-e18fea9a6526, Version=2.0.1'} 2022-04-26 18:30:34,631 [ DEBUG] urllib3.connectionpool: Starting new HTTPS connection (1): jellyfin.local:8920 Process STrayProcess-1: Traceback (most recent call last): File "/usr/lib/python3.10/multiprocessing/process.py", line 315, in _bootstrap self.run() File "/home/me/.local/lib/python3.10/site-packages/jellyfin_mpv_shim/gui_mgr.py", line 439, in run from pystray import Icon, MenuItem, Menu ModuleNotFoundError: No module named 'pystray' 2022-04-26 18:30:34,653 [ DEBUG] urllib3.connectionpool: https://jellyfin.local:8920 "GET /system/info/public HTTP/1.1" 200 None 2022-04-26 18:30:34,654 [ INFO] JELLYFIN.jellyfin_apiclient_python.connection_manager: calling onSuccessfulConnection with server pc 2022-04-26 18:30:34,654 [ INFO] JELLYFIN.jellyfin_apiclient_python.api: Sending get request to system/info 2022-04-26 18:30:34,654 [ DEBUG] JELLYFIN.jellyfin_apiclient_python.api: 5 2022-04-26 18:30:34,654 [ DEBUG] JELLYFIN.jellyfin_apiclient_python.api: {'Accept': 'application/json', 'Content-type': 'application/x-www-form-urlencoded; charset=UTF-8', 'X-Application': 'Jellyfin MPV Shim/2.0.1', 'Accept-Charset': 'UTF-8,*', 'Accept-encoding': 'gzip', 'User-Agent': 'Jellyfin-MPV-Shim/2.0.1', 'x-emby-authorization': 'MediaBrowser Client=Jellyfin MPV Shim, Device=pc, DeviceId=bef57e4f-8252-4309-97da-e18fea9a6526, Version=2.0.1', 'X-MediaBrowser-Token': 'REDACTED'} 2022-04-26 18:30:34,655 [ DEBUG] urllib3.connectionpool: Starting new HTTPS connection (1): jellyfin.local:8920 2022-04-26 18:30:34,666 [ DEBUG] urllib3.connectionpool: https://jellyfin.local:8920 "GET /system/info HTTP/1.1" 200 None 2022-04-26 18:30:34,668 [ DEBUG] JELLYFIN.jellyfin_apiclient_python.credentials: credentialsupdated 2022-04-26 18:30:34,668 [ DEBUG] JELLYFIN.jellyfin_apiclient_python.connection_manager: resolving connect with result: {'Servers': "[{'address': 'https://jellyfin.local:8920', 'Name': 'pc', 'Id': '2cff12abeaca4db1929a0228ddb62091', 'DateLastAccessed': '2022-04-26T18:30:34Z', 'UserId': '5f40482ebff24b08ac64ff15d688adb6', 'AccessToken': 'REDACTED', 'Users': [{'Id': '5f40482ebff24b08ac64ff15d688adb6', 'IsSignedInOffline': True}], 'uuid': '049cef0d-3009-416a-b77b-950ce6bb8187', 'username': 'me', 'connected': True}]", 'State': 3} 2022-04-26 18:30:34,668 [ INFO] JELLYFIN.jellyfin_apiclient_python.client: User is authenticated. 2022-04-26 18:30:34,669 [ DEBUG] urllib3.util.retry: Converted retries value: 3 -> 'Retry(total=3, connect=None, read=None, redirect=None, status=None)' 2022-04-26 18:30:34,669 [ DEBUG] urllib3.util.retry: Converted retries value: 3 -> 'Retry(total=3, connect=None, read=None, redirect=None, status=None)' 2022-04-26 18:30:34,669 [ INFO] JELLYFIN.jellyfin_apiclient_python.ws_client: Websocket url: wss://jellyfin.local:8920/socket?api_key=REDACTED&device_id=bef57e4f-8252-4309-97da-e18fea9a6526 2022-04-26 18:30:34,670 [ DEBUG] urllib3.connectionpool: Starting new HTTPS connection (1): jellyfin.local:8920 2022-04-26 18:30:34,682 [ INFO] JELLYFIN.jellyfin_apiclient_python.ws_client: --->[ websocket ] 2022-04-26 18:30:34,682 [ DEBUG] event_handler: Unhandled Event WebSocketConnect: None 2022-04-26 18:30:34,855 [ DEBUG] JELLYFIN.jellyfin_apiclient_python.ws_client: ForceKeepAlive received from server. 2022-04-26 18:30:34,855 [ DEBUG] JELLYFIN.jellyfin_apiclient_python.ws_client: KeepAlive received from server. 2022-04-26 18:30:35,096 [ DEBUG] urllib3.connectionpool: https://jellyfin.local:8920 "POST /Sessions/Capabilities/Full HTTP/1.1" 204 0 2022-04-26 18:30:39,460 [ DEBUG] event_handler: Handled Event Play: {'ItemIds': ['a2e297420da6222e06c6b4b7a07c3fb9', '761ae45851dc13c2ccc8473618051518', '96e7f2fb52cc7e684b0fa0b720b04c8e', '4ff024759405514299ace194987d3781', 'c6e6872c95a6c7e6a9ec6c28828b5c4b', '792ed72354504280dbdacbd324f8dc1f', '17c8a2ddb966485b3d13940780ca7b38', '079fefe194a9372a008ce032a6d01b1a', 'd6bb9b8bf4f4aad5b949a54f6bf6243a', 'fd70f3f3e0634095afc079f424aa6a97', '0a973f19bb914027556010df4ff33691', '8716d8bdf4a0eac1153e2e50c363ac1d'], 'PlayCommand': 'PlayNow', 'ControllingUserId': '5f40482ebff24b08ac64ff15d688adb6', 'ServerId': '2cff12abeaca4db1929a0228ddb62091'} 2022-04-26 18:30:39,471 [ DEBUG] urllib3.connectionpool: https://jellyfin.local:8920 "GET /Users/5f40482ebff24b08ac64ff15d688adb6/Items/a2e297420da6222e06c6b4b7a07c3fb9 HTTP/1.1" 200 None 2022-04-26 18:30:39,475 [ DEBUG] event_handler: EventHandler::playMedia