search

jellyfin / jellyfin-mpv-shim

MPV Cast Client for Jellyfin
Other
1.58k stars 93 forks source link

Python version needed to build #263

Open IrishBumfuzzle opened 2 years ago

IrishBumfuzzle commented 2 years ago

Is your feature request related to a problem? Please describe.

In the readme.md, the version of python required to build the project is not mentioned. As currently the pythonnet dependency is only available till v3.8

Describe the solution you'd like

Mentioning the python version would be great.

IrishBumfuzzle commented 2 years ago

Also this line need to be edited, Extract the mpv-1.dll from the file and move it to the jellyfin-mpv-shim folder. in building for windows to mpv-2.dll

iwalton3 commented 2 years ago

You can use older versions of those packages. I had to upgrade it due to issues with CI builds. You can also just omit some optional dependencies but it’ll run with reduced functionality.

Last I recall this will work with a version as old as Python 3.6.

IrishBumfuzzle commented 2 years ago

You can use older versions of those packages. I had to upgrade it due to issues with CI builds. You can also just omit some optional dependencies but it’ll run with reduced functionality.

Last I recall this will work with a version as old as Python 3.6.

I meant to say that it doesn't build with new versions of python like 3.10.

iwalton3 commented 2 years ago

Oh if you are building for windows it is kind of a mess too. Your best bet until I get a new release actually finished is read the CI code.

IrishBumfuzzle commented 2 years ago

I'll make do, thanks.

iwalton3 commented 2 years ago

Yeah unfortunately the windows build seems to break every time I go to make changes to this project as of late.