search

jellyfin / jellyfin-mpv-shim

MPV Cast Client for Jellyfin
Other
1.5k stars 88 forks source link

Update bulk_subtitle.py #290

Closed alanazar closed 5 months ago

alanazar commented 1 year ago

Weblate best practice: "The string uses three dots (...) instead of an ellipsis character (…)" Reference to error: https://translate.jellyfin.org/translate/jellyfin/jellyfin-desktop/en/?q=check:ellipsis%20OR%20dismissed_check:ellipsis

iwalton3 commented 1 year ago

I know some installations of MPV have issues with font rendering enough to make me hesitant to do this. I don't see any reasons listed here that actually apply to this code base: https://docs.weblate.org/en/latest/user/checks.html#mismatched-ellipsis

alanazar commented 1 year ago

What you mentioned could be the reason why the only 2 outstanding "errors" for ellipsis characters are within MPV and nowhere else, because someone decided not to touch it. However, if that was the case then wouldn't have the other Weblate translations also created issues? https://translate.jellyfin.org/search/jellyfin/jellyfin-desktop/?offset=1&q=%E2%80%A6&sort_by=-priority%2Cposition&checksum=

Either way, it's only a matter of keeping weblate updated consistently so there's no negative impact keeping it as it is. The safest option could be to just remove the 3 dots altogether.

This is my first pull request so bear with me :D