jellyfin / jellyfin-mpv-shim

MPV Cast Client for Jellyfin
Other
1.59k stars 93 forks source link

Thumbnailer.lua not working with external mpv. #293

Open KiltedTraveller opened 2 years ago

KiltedTraveller commented 2 years ago

After a bit of tinkering I managed to get my external MPV client to load using mpv-shim. Everything is working perfectly now (all my scripts and shaders) except for thumbnailer. It uses ffmeg to generate thumbnails for the seekbar. It's a pretty popular mpv script.

My guess is that it's due to the fact that shim caches the video as if it's streaming, but I'm not 100% sure.

It works fine when opening video files natively using MPV.

There doesn't seem to be any error messages in the MPV console.

Is there a solution?

njlxyaoxinwei commented 1 year ago

I use https://github.com/po5/thumbfast and had success with setting network=yes in script-opts/thumbfast.conf

ausar47 commented 1 year ago

I use https://github.com/po5/thumbfast and had success with setting network=yes in script-opts/thumbfast.conf

I set network=yes in both shim mpv and the external mpv I'm using, the thumbnails did show but were all black images. Is there anything else I should config, like enabling chapter image extraction in "manage library"? Many thanks.

po5 commented 1 year ago

I am the developer of thumbfast. As far as I understand it, jellyfin people reimplemented the thumbfast API, you do not need (and should not install) the thumbfast.lua script yourself the usual way. It redirects standard thumbfast calls to their "trickplay" thumbnail format, which can be generated with the jellyscrub plugin.

@ausar47 You also need to disable the compatibility layer if you really want to use real thumbfast https://github.com/jellyfin/jellyfin-mpv-shim/issues/329#issuecomment-1466004749

iwalton3 commented 1 year ago

Correct that is exactly what I did. If you want to use the original thumbfast script, disable trickplay in the MPV Shim config.