search

jellyfin / jellyfin-mpv-shim

MPV Cast Client for Jellyfin
Other
1.5k stars 88 forks source link

sub-scale in mpv.conf not respected and is set to 1 on every video start #296

Closed LeaPhant closed 1 year ago

LeaPhant commented 1 year ago

Describe the bug Putting a sub-scale (e.g. sub-scale=1.1) into mpv.conf either using internal or external mpv does not actually change the subtitle scale. When opening a file via mpv directly it works. Adjusting via keys or command mode after launch also works but when changing to another episode the scale resets to 1.

To Reproduce Steps to reproduce the behavior:

  1. Put sub-scale=2 in mpv.conf
  2. Launch jellyfin-mpv-shim and start playing a video
  3. Subtitles still use scale of 1

Expected behavior Subtitles should scale with the sub-scale value.

Desktop:

LeaPhant commented 1 year ago

During all the time I've spent trying to work around this I've never noticed subtitle_size in conf.json, only after finally opening an issue. Welp maybe it will help someone else who finds this in the future at least.